Comments (5)
I just assumed that people would keep as 'default' a setup as possible and I personally always number my vserver files to control load order (i.e. 10-mailcow.conf). But, I like your suggestion. I'll review the suggested code later today when I have a few minutes. Thanks! Nice catch :-)
from mailcowbackup.
Anytime! My pull request doesn't fix this issue, but I don't think a fix would be too complex.
from mailcowbackup.
I'm likely redoing this script this weekend (I hope) to make it POSIX compliant instead of using BASH so it can be used by people on more systems. I think I'll replace the automatic path search for the mailcow.conf file entirely with parameter input. Right now, the script only allows you to search for a differently named file. I'll change that to requiring the parameter to specify a full path.
If I don't get around to completely re-writing the script this weekend, I'll implement the change in this (BASH) version and do a new release. Thanks again @hockeymikey for pointing this out!
Oh, and I'll merge you commit in the meantime also since it's a great addition to the script that I'm totally stealing and putting into the new version. I just have to figure out how to sync the change with my actual private server I use and not just here on github.
from mailcowbackup.
- merge to take care of non-standard container names (commit fb8091e)
- remove auto-searching for 'mailcow.conf' and require user provide full path via '-m' script parameter (commit bbbdf38)
These fixes are in the v1.6 release.
from mailcowbackup.
Any time, glad to hear. Thanks for creating such a great project, just happy to help.
from mailcowbackup.
Related Issues (13)
- Cronjob failing due to missing PATH HOT 3
- Wrong formating in details file... HOT 1
- [Suggestion] add version of script in help HOT 2
- backup script not working with docker compose v2 HOT 3
- same issue as in #13 HOT 3
- Reports can't start Dovecot/Postfix HOT 7
- What means "Line 1: Path to borg base directory" HOT 15
- Wiki is down? HOT 8
- howto restore from a backup HOT 9
- error with borg 1.0 HOT 3
- How to backup to local folder HOT 3
- Feature ideas and / or requests - Colours in log and SSH port config HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailcowbackup.