Comments (3)
It seems pretty common for many programs to expect the user to alter their cron path manually as needed. Also, the borg documentation specifically suggests installing/symlinking to /usr/bin/borg
so that it can be found by all systems.
However, it is not a difficult change to make to the script directly to detect the path and use it. I think that's easier and better than assuming the user can find the right path and add it to the details file. Plus, you're probably right, it should be using full paths wherever possible since it's designed to run in a cron environment. I'll add it to my weekend-workflow and hopefully have the change pushed before Monday.
Cheers. Glad you got the path thing figured out, btw. I forgot about it in the documentation since I'm used to just updating my crontab paths -- nice catch :-)
from mailcowbackup.
thanks for considering. I must have missed that in the borg documenation and never stunbled over that crontab issue. But I'll guess you learn something new every day :)
from mailcowbackup.
I decided to go with a command-line parameter instead of auto-detecting in the script or a variable in the details file. Here's my reasoning:
- borg should be installed with a symlink to
/usr/bin/borg
(and really/usr/bin/borgfs
for compatibility) as per the program documentation. If it is installed in that location, it should be in the path for most systems' cronjobs. - putting it in the details file I feel would be confusing to some users. The packaged installation and those following the direct-install instructions in the documentation would be installing to the default location anyways, so having this in the details file might make people think they need to install a separate version or something. I'm not sure about this confusion, but it was suggested to me as a possible problem by a few other people I talked to.
- I considered having the script just 'find' borg. But then I thought about people with very large file systems and the fact that even on NVMe/SSD drives a full disk search can eat time. That could be annoying if you (like me) run a backup every few hours instead of just once a day or something.
I'm closing this for now, but if you disagree with this choice, please let me know and I'll take it under consideration. Obviously, I value your opinion since this was on your suggestion anyways so I feel free to speak up if you want :-) Just re-open the issue if you like.
For reference, this change is implemented in Version 3.5
from mailcowbackup.
Related Issues (13)
- Wrong formating in details file... HOT 1
- [Suggestion] add version of script in help HOT 2
- backup script not working with docker compose v2 HOT 3
- same issue as in #13 HOT 3
- Multiple mailcow.conf HOT 5
- Reports can't start Dovecot/Postfix HOT 7
- What means "Line 1: Path to borg base directory" HOT 15
- Wiki is down? HOT 8
- howto restore from a backup HOT 9
- error with borg 1.0 HOT 3
- How to backup to local folder HOT 3
- Feature ideas and / or requests - Colours in log and SSH port config HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailcowbackup.