ashdavies / rx-firebase Goto Github PK

Calling setPersistenceEnabled must be performed before any database operation thus calling via RxFirebaseDatabase crashes the application

Include auth module for updated Firebase sdk

Include sample application to demonstrate usage of the library modules

App crashes with firebase libs version 10.2.6 with error
Checked on 10.0.1 - all ok.

Caused by: java.lang.NoSuchMethodError: No virtual method zzTu()Ljava/lang/String; in class Lcom/google/firebase/FirebaseApp; or its super classes (declaration of 'com.google.firebase.FirebaseApp' appears in ....)

Please update versions in you library. Thanks

I've been wondering about the backpressure strategy you have set for the flowable on database. Right now it's set to buffer, which will maintain a buffer of ALL events. I'm not sure that this is the right approach. If the purpose is to wrap firebase with rx, there's rarely a good reason to present inaccurate snapshots to any consumer. I think you should be using the LATEST backpressure strategy. In LATEST, if n writes occur before n-1 writes are read by the subscriber, the latest value will be overwritten on the unread write. This seems to be exactly what firebase does in an non-rx flow.

What do you think?