aschulenberg / prj-rev-bwfs-dasmoto Goto Github PK

https://github.com/aschulenberg/prj-rev-bwfs-dasmoto/blob/master/Dasmotos%20Arts%20and%20Crafts/index.html#L1-L33

Your HTML is nicely indented/formatted. Make sure to keep up the good work!

https://github.com/aschulenberg/prj-rev-bwfs-dasmoto/blob/master/Dasmotos%20Arts%20and%20Crafts/index.html#L8-L32

You made great use of ID's and classes, especially for your paint, brushes and frames elements. Knowing when to use id's vs classes is a concept that many learners seem to confuse, so great job getting that right!

Summary Grade: Satisfactory

Good job! Your files are organized nicely, and you did a great job of following the client specification -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed excellent code practice, so make sure to keep that up!

I have made some comments in your code to take note of. First off, great job making use of id's and classes appropriately -- many learners seem to confuse this concept, so great job getting that right. In future projects, you should make sure to comment the main parts of your HTML and CSS – this becomes increasingly important as your projects get larger and more complex. This greatly helps your development flow, especially as your projects get larger and more complex since they serve as a reminder to why you decided to code something a particular way. Here is a quick reminder on commenting in HTML and CSS:

Moreover, nice job making sure to format/indent your HTML properly.

Great job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs).

https://github.com/aschulenberg/prj-rev-bwfs-dasmoto/blob/master/Dasmotos%20Arts%20and%20Crafts/index.html#L2-L33

Make sure to comment the main parts of your HTML in future projects. This becomes increasingly important as your projects get larger and more complex. Here is a quick reminder on commenting in HTML:

https://github.com/aschulenberg/prj-rev-bwfs-dasmoto/blob/master/Dasmotos%20Arts%20and%20Crafts/resources/style.css#L1-L30

Your CSS is short, clean and succinct -- good job! An area of improvement is to make sure to comment your main stylings so that it's clear why you're styling elements a particular way. Here is a quick reminder on commenting in CSS: