asantibanez / laravel-subscribable-notifications Goto Github PK

When a user that is subscribed to at least one notification is soft deleted, notifications are still trying to be sent to them but are failing because the contact info no longer exists (soft deleted).

We need to scope the query that get's the list of users to send the notification to.

Fix add $with = ['user'];

class NotificationSubscription extends Model
{
    use HasFactory;

    protected $guarded = [];
    protected $with = ['user'];

    public function user()
    {
        return $this->belongsTo(NotificationSubscriptionManager::userModel());
    }

@asantibanez Will this package get support for Laravel 9? If I submitted a PR, will you merge it?

Dispatch method send notification to all subscribed user for specific order, But it should be sent to only subscriber user of that order.

For example:

OrderCreated notification subscribers 3 users, like user_id: 5, 15, 26

Order owner user_id is 26

So OrderCreated::dispatch($order) only should send to 26, Not for all 5, 15 and 26.

config:

'subscribable_notifications' => [
        OrderCreated::class,
        OrderEdited::class,
    ],

OrderCreated Notification:

    public static function subscribableNotificationType(): string
    {
        return 'Order-Created';
    }

Controller function:

   public function sent_email()
    {
        $order = Order::find(Session::get('order_id'));
        $order->setStatusConfirmed();
       // $order->user->notify(new OrderCreated($order));
        OrderCreated::dispatch($order);
        return response()->json(['status' => 'success']);
    }

Great package for notification subscription. Are you extending this package to enable notifications of a particular model events.

Need to be able to delay the sending of a Notification, and would like it to follow the Laravel api for such use case.

$delay = now()->addMinutes(10);
 
InvoicePaidNotification::dispatch($invoice)->delay($delay);