arup-group / actions-city-modelling-lab Goto Github PK

Looks like there's an issue where conda/mamba/micromamba update ... won't actually update any defined dependencies that are unpinned. This is a problem as our latest implementation, moving from setup-micromamba to setup-miniconda (#26) uses this functionality.

The solution is to use mamba create --yes -n [env-name] to re-create the environment from scratch rather than updating the boilerplate environment that is created by setup-miniconda.

The recommended method to set up the aws upload action "role" is to set role-to-assume. I'm not sufficiently familiar with AWS to know if we should be following this recommendation. Can you comment @mfitz?

the docs deployment workflows should have all the same environment building args available as the pytest workflows have, to e.g. add conda channels to the environment creation.

Some of our Docker image builds downstream of our GitHub CI builds look for an optional file called image_tags in the repo. If this file exists, the Docker image published by the build will add a tag to the image for each line in image_tags.

The mechanism for generating these tags will vary from project to project. For example, with Maven-based projects, we often want to create a tag that uses release info parsed from pom.xml, but Python and other projects will want to generate the image tags in different ways.

If we add an optional input parameter for this tag value to the input parameters of the AWS upload reusable action, we can allow the caller builds to do whatever needs to be done to generate the tag, but create the image_tags file inside the reusable action.

Although having our CI builds "know something" about downstream builds that they should really be completely unaware of is a bit hacky, it's a small change that will not impact users and is much simpler than moving away from the one-size-fits-all downstream Docker builds mechanism we currently use for CD.

See actions/cache#752

It's caused by environments being composed of a lot of small files, which Windows takes forever to unpack.