RFC: Protect main/master branches about readme HOT 5 CLOSED

I'd like to resurface some issues with this now that's in practice.

First layer of protection- this prevents direct commits to the main branch. This seems great! No more sneaky pushes to master (or the more likely accidental one). I can see this saving someone from doing this inadvertently.

Second layer of protection- also requiring that all PR's must have a passing reviewer. This opens up a can of worms that I think this RFC may not have realized: what's the difference between assignee and reviewer? How does requiring a reviewer play with Peril, which already requires an assignee? How does this interface with 'merge on green'?

I sort of think that everyone was on board with the first layer, but the second layer feels a tad iffier to me. It's kind of like the branch protection rule was maybe the main 'goal' of the RFC and the review approval requirement maybe a bit secondary to that? Wonder if we should roll that back or make new one for it.

from readme.

This seems good - no dissent from me! I do wonder if there's a middle ground between the soft and hard ways where we pick some repos and enable this there. Off the top of my head I'd go with:

• gravity
• force
• eigen
• metaphysics
• volt

I think if we do it to those projects it's possible the practice will radiate out from there. 🤷

from readme.

Thanks for the list @jonallured, I enabled master/main branch protection on all of them

from readme.

Resolution

We decided to do it.

Level of Support

2: Positive feedback.

Next Steps

I've protected main/master branches on the five main repos listed above. From now on, everyone should opportunistically protect main/master branches on any repo they work on, preferably using settings similar to those used on the above listed repos.

Exceptions

None, currently.

from readme.

Yes, you're absolutely right, and I apologise for getting carried away when I changed the branch protection settings. I've turned off the Require approvals setting on Gravity and Volt (the only of the five repos that still had it enabled).

from readme.