auto-delete approval when approved about django-approval HOT 5 CLOSED

Hi, and thanks for your ticket.
It's something I have not thought through enough, but I can have a look at this.
I'll have some time tomorrow morning to implement your change, I'll send an update when it's done

from django-approval.

Hey mate,
whats the status?

from django-approval.

Hey,
You're lucky, I'm currently merging a pull request and...

from django-approval.

...it's done!!

from django-approval.

Hey, the change is incorrect. The new if-statement leads to the else block if the model is approved.
And the else block shows an "ImproperlyConfigured" error.
The solution is to move the last check down into the if-statement.

Replace

if hasattr(obj, "approval") and obj.approval and not obj.approval.approved:

with

if hasattr(obj, "approval") and obj.approval: 
    if obj.approval.approved != True:

(like it was in my original solution provided in the first post in this issue)

from django-approval.