Wrong package on pypi about django-approval HOT 5 CLOSED

I think you are still missing the templates directory on the package.

from django-approval.

You're absolutely right and it happened on another project I worked on recently. I made a change in pyproject.toml to use hatchling, and tried things in order to properly include the code packages. It ended up working properly (namespaces also), and I only recently noticed it did not work at all on other machines.

I'm looking at it, I'll hit you up when it's fixed. Thanks for the alert.

from django-approval.

I think I got it. Python packaging is an infamous nightmare, the issue was with:

• using hatchling (the wheel generated was empty but the tar.gz was ok)
• using setuptools (I had to use the default layout for anything to work)

Tell me if this looks fixed for you.

from django-approval.

It's fixed. thanks.

from django-approval.

For the record, I've just uploaded a new version on PyPI that fixes the templates folder and only displays warning in the admin if an object is not approved.

from django-approval.