Version check comparison error. about siren HOT 17 CLOSED

Even after merging this PR?

c0e4027

from siren.

Also, sometimes this happens IF the user is trying to download the app the moment it the servers update. Unfortunately, the server metadata update is faster than the app being propagated to the CDNs.

from siren.

Yeah even after merging that PR... that PR I sent resolves another issue...
Why is this comparison check being done btw if there is a comparison check already being done in another place?

from siren.

Also, sometimes this happens IF the user is trying to download the app the moment it the servers update. Unfortunately, the server metadata update is faster than the app being propagated to the CDNs.

Actually, no. The meta data was all up to date, I checked the results object Siren grabs, and it was in a loop because of the problem code I provided above. This happens because of the decimal 0, mathematically, they're the same number, and therefor this comparison check should return false, but instead it's returning true..

from siren.

Ok I notice one comparison is being done to determine the type of upgrade alert that should be shown - in the showAlert() method, while the first filter in the isAppStoreVersionNewer() method acts as a way to determine if a new update is required at all based on the ascending check... hmm, this as you can see errors out in this edge case.

from siren.

In regards to your suggestion that this might be related to a meta data sychronisation:
The version accepted into the app store was the new build submitted, version 16.0. The app from the app store was then installed and Siren used the local version number of the bundle which was 16.
This screenshot is for futher affirmation to demonstrate that this had nothing to do with synchronisation issues.

from siren.

Thanks for checking that out.

I'm a bit exhausted right now, so I can't fully process why/what is going on. I'll take a look tomorrow.

from siren.

Hey, I hope you had a well rested night last night.

Here's the damage that was caused last night, had people posting negative reviews right away at which point we had to take Siren out, and release another version straight after back into itunes connect... hoping apple would accept right away, but the damage was already done, atleast 180 users within 10 minutes were affected.
At least one could say that the negative reviewers actually care? hmm. Anyway.

How's it going now anyway @ArtSabintsev ?

from siren.

Siren's only tested to go from similar versioning systems:

16 -> 17
16.0 -> 16.1
16.0.0. -> 16.0.1

I never tested it to go from 16 -> 16.0, though others have tested it to go from 16->16.1, and that's worked, so it should technically work as long as the number is different.

Is that what you ended up doing? Going from 16 -> 16.0?

from siren.

I am closing this issue for now, but we can continue the discussion in here at your convenience.

from siren.

Is there a reason you're closing this issue considering this issue hasn't been resolved? I think others should be made aware that this issue exists as they are most likely to implement this package for a production environment. Do you agree hiding the issue from the dashboard - which closing an issue does as though it's been resolved - will not help?

from siren.

That's weird, I thought I posted a response to your previous message,

Here it is again, No. I didn't go from version 16 to 16.0, apple's itunes connect will not allow you to do that. I went from version 15.0.1 to version 16 which is a similar versioning system.

from siren.

Wait, you went from 15.0.1 -> 16, not 16.0.0?

from siren.

As a follow-up, I am simply trying to understand your problem. In the 4 years that Harpy and Siren have been around, I have never had an issue like this come out. So, no, I don't believe this issue needs to be visible, as it's a one-off case, and the problem is not apparent to me.

Now, just so we're crystal clear, is the problem that you went from an x.y.z to an x versioning system? If so, what warranted that decision?

Also, I wrote a few tests this weekend, and my test shows that Siren handles that use case without issue.

https://github.com/ArtSabintsev/Siren/blob/master/Sample%20App/SirenTests/SirenTests.swift#L79-L82

from siren.

@getaaron Can you chime in here as well (in case I'm missing something)? Thanks!

from siren.

No problem. Great package nonetheless.
I'll just have to stick to the same format versioning system :) i.e. should have updated to 16.0.0
Thank you for your input and your time @ArtSabintsev.

from siren.

Thanks for following up!

Good luck, and if you continue using it, feel free to post issues and PRs!

Have a great week!

from siren.