When rule is set to .critical, previous skipped version setting should be ignored about siren HOT 4 CLOSED

Man oh man - are you the same Alex from Swaag? It's been a long time.

I need to think through this problem and I will get back to you later tonight

from siren.

Yup, just tested this out in the sample app by running the following functions in AppDelegate

1. defaultExample()
2. hyperCriticalExample()

When I ran 1, clicked Skip, closed the process. Relaunched the app with 2, it didn't pop the modal.

This is totally a bug that's been in the code for 7.5 years that I've never come across personally.

Feel free to open a PR at your leisure. I'll be out of pocket for about a week, but will check back when I'm back if you do end up opening a PR.

from siren.

@ArtSabintsev Yep, that's me. Can't believe you remember that far back 😄 It's nice to see all the iOS projects you have. This one has been especially useful. I just opened up a small PR with a fix for this issue.

from siren.

Thank you! Closing this one in favor of that one.

from siren.