hideWindow() causes a crash about siren HOT 6 CLOSED

Hey,

Would you mind making a sample project delineating the problem and solution?

I've never come across this issue.

Thanks!

from siren.

@ArtSabintsev
Please just use your sample project and add

func applicationWillEnterForeground(application: UIApplication) {
Siren.sharedInstance.checkVersion(.Immediately)
}
func applicationDidBecomeActive(application: UIApplication) {
Siren.sharedInstance.checkVersion(.Daily)
}

into your delegate class. Try open the app and press home button and go back again. Clicking the next time button will crash the App.

from siren.

Hi,

I think that checkVersion(_:) with parameter SirenVersionCheckType.Immediately should not be called from applicationWillEnterForeground(_:) and/or applicationDidBecomeActive(_:)) because that could lead to several alerts displayed on top of each other (e.g. in the situation that rex3du described) which can be a problem when not using SirenAlertType.Force (like shortly mentioned in the readme).

When using any other SirenAlertType where the alert can be dismissed the hideWindow() gets called each time you close the alert - at least when using UIAlertController (iOS 8).
In this method Siren.updaterWindow is set to null (#515) which leads to a crash when closing the second alert (#514: "unexpectedly found nil while unwrapping an Optional value").

When you need to call checkVersion(.Immediately) from e.g. applicationWillEnterForeground(_:) and you do not want to have several alerts on top of each other I would suggest executing the code in checkVersion(_:) only if Siren.updaterWindow is nil.

Thanks for your great work on this excellent project!

from siren.

@m-herold your are correct. checkVersion(.Immediately) causes the issue. @ArtSabintsev I suggest remove the example in the Setup Instruction which is using checkVersion(.Immediately) from e.g. applicationWillEnterForeground(_:).

from siren.

Will look into this after the Swift 2 branch is merged.

from siren.

Fixed in Swift 2 branch.

Thanks!

from siren.