artipie / maven-adapter Goto Github PK

LocalArtifactResolver resolves an artifact in a local repository by its relative path.
The class was not covered by test to split the original pull request.

The puzzle 37-329dc9a9 from #37 has to be resolved:

The puzzle was created by @Nimmaster on 18-Feb-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Class com.artipie.maven.aether.AetherRepository needs unit testing.

The puzzle 58-abf1aafd from #58 has to be resolved:

The puzzle was created by paulodamaso on 26-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

org.eclipse.aether.spi.locator.ServiceLocator is a ServiceLocator pattern interface. It creates/retrieves services by matching service class. If the service was not yet registered it simply returns null forcing you to make a null check on each invocation.
We should hide null checks in another class implementing the interface.

To pass LocalRepository as constructor arg

Remaining class affects underlying ByteBuffer on read operations.

"A developer's entrypoint" and further information in readme file seem to be outdated, for example Repository interface is deprecated and does not have method upload.

May be it will be better to update readme after all deprecated classes will be refactored and removed.

Use http v8.4

The puzzle 54-83abca7b from #54 has to be resolved:

The puzzle was created by paulodamaso on 13-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

It seems the parent was missed in the maven-adapter pom.xml file.

So most of the configurations coming from it and jcabi-parent are missing.

Now it accepts InputStream, it should be refactored to java.util.Flow.Publisher<ByteBuffer>

The puzzle 85-bba77ac2 from #85 has to be resolved:

The puzzle was created by @g4s8 on 21-May-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Let's support snapshot repositories. Start with investigating how snapshot repository works (add it to the readme), then implement integration tests, then actual implementation.

Use Maven libraries.
Scope: no snapshots, plugins, parents

The puzzle 1-539b0424 from #1 has to be resolved:

The puzzle was created by Nimmaster on 30-Jan-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 54-affb36a2 from #54 has to be resolved:

The puzzle was created by paulodamaso on 10-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 37-15918c08 from #37 has to be resolved:

The puzzle was created by @g4s8 on 26-Feb-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

I noticed the link to the travis badge is incorrect in the README, it points to another repository

Now checksum attribute reads the artifact file itself. It should read from a checksum file.

The puzzle 54-9c5a8d8c from #54 has to be resolved:

The puzzle was created by paulodamaso on 10-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 72-b493e50d from #72 has to be resolved:

The puzzle was created by Victor Noël on 08-May-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

FileCoordinates contains two methods: coords() and path() that throw UnsupportedOperationException. We should implement it (and unit test too).
The class was not implemented to split the original pull request.

The puzzle 72-9e640b6a from #72 has to be resolved:

The puzzle was created by Victor Noël on 08-May-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Let's reutrn simple text list (or primitive HTML list) of items in repo or artifact paths. E.g. if the request is pointing to repository like host/maven/ then we should return list of artifacts in this repo, same for artifact host/mave/com/artipie/asto reutrns list of metadata and versions.
Similar to Maven central:

• https://repo.maven.apache.org/maven2/com/artipie/asto/
• https://repo.maven.apache.org/maven2/
• https://repo.maven.apache.org/maven2/com/artipie/asto/0.12.0/

Set project pom.xml to PPOM

To introduce a method for downloading artifacts in Repository

The puzzle 64-cc923fd8 from #64 has to be resolved:

The puzzle was created by Victor Noël on 11-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Refactor maven adapter base interfaces and entry points:

• it should be reactive - no support for InputStream and OutputStream, only Publisher<ByteBuffer> from reactivestreams.org
• Entry point class should encapsulate Storage interface from artipie/asto dependency and use it to generate metadata by key, e.g. new Maven(storage).update(new Key.From("org/artipie/maven-adapter"))

Ask me if something is not clear.

Asto storage should be introduced to Maven library lifecycle

org.eclipse.aether.spi.locator.ServiceLocator and org.eclipse.aether.RepositorySystemSession are principal interfaces in Maven library. They should be created as instance-per-request which makes them quiet unwieldy.
I propose to create a new class (say com.artipie.maven.aether.Context) which:

• implements these two interfaces and passes method calls to delegate fields
• absorbs com.artipie.maven.aether.ValidatingServiceLocator
• stores contextual values like correlationId in org.eclipse.aether.RepositorySystemSession#getData()
  Its instances should be created by a factory class com.artipie.maven.aether.ContextFactory
  which accepts com.artipie.asto.Storage and org.eclipse.aether.repository.LocalRepository as a constructor args. It absorbs com.artipie.maven.aether.ServiceLocatorFactory and com.artipie.maven.aether.SessionFactory.

Absorbs #41

More:

ServiceLocator and RepositorySystemSession are not thread-safe. RxJava may reschedule operator execution in another thread exposing these objects to race condition. You should investigate how to solve it.

Apparently the build fails from time to time (see #67 and #68 (comment)).

The problem is that the AstoFileTest tests are using asto.save that returns a CompletableFuture and get is not called on it, so the test does not wait for the future to complete before continuing.

The puzzle 64-a4ea9323 from #64 has to be resolved:

The puzzle was created by Victor Noël on 11-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Testing facility class com.artipie.maven.test.OptionalAssertions requires its own unit tests

• the project uses org.slf4j.Marker in logging statements, logback config pattern should support it.
• set WARN level for io.netty

Implement Repository with Maven libraries.

The puzzle 72-e21c7763 from #72 has to be resolved:

The puzzle was created by Victor Noël on 08-May-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

With scope test

It's not clear how to use this module, which classes to use as entry points and how to construct it. @Nimmaster please add these details to usage section of README.md.

The puzzle 71-c580cc48 from #71 has to be resolved:

The puzzle was created by @g4s8 on 23-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

To delete files in local repository just like in AutoCloseablePath.
Consider and putting artifacts directly to local repository, dropping AutoCloseablePath.
Introduce an interface for different deletion strategies in local repositories - possibly LRU time-based policy.

Let's investigate what API methods Maven repo supports and add these methods.
Start this task in following order:

1. Documentation update: let's add specification and references about maven repo API in README
2. Create integration tests for API
3. Implement API methods.

Try to decompose this task as much as possible using todos (e.g. one todo per API)

Set checksums in Task object in com.artipie.maven.aether.AstoTransporter#implGet like:

task.setChecksum("MD5", /* get checksum from Asto */);
task.setChecksum("SHA1", /* get checksum from Asto */);

Now, if checksums are not set, Maven library logs warnings like:

WARN  o.e.a.i.impl.WarnChecksumPolicy -  Could not validate integrity of download from asto://artipie.com/maven/org/example/artifact/maven-metadata.xml
org.eclipse.aether.transfer.ChecksumFailureException: Checksum validation failed, no checksums available

It is a place for possible optimization - to fetch a binary and its checksums in one call.

Maven relies heavily on file system. Before processing an artifact, we should put it in some temporary storage.

The puzzle 57-0a27a98f from #57 has to be resolved:

The puzzle was created by paulodamaso on 23-Mar-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Now com.artipie.maven.FileCoordinates expects artfiact name to be as colon-delimited string. It should be URI path segment

The puzzle 10-5f36658f from #10 has to be resolved:

The puzzle was created by @Nimmaster on 10-Feb-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Implement Maven proxy repository (or Maven mirror) with authentication and cache support. Maven mirrors are described here: https://maven.apache.org/guides/mini/guide-mirror-settings.html

Multi-remote

Maven proxy can be used to merge multiple remote repositories into single one. In this case, proxy repository is trying to access remotes one by one in specified order until find applicable artifact.

Example: user uses Artipie Maven mirror to get artifacts from custom private repository and from Maven central, user configures Artipie Maven mirror to first search artifacts in private repository, and then from central, if artifact was not found in private repo.

Authentication

Proxy should be able to use authentication to access remote repository. The use case is when the user is giving access to different repositories through proxy or hiding actual credentials on proxy side.

Caching

Proxy should be able to cache artifacts and metadata, the user can configure the TTL and size of the cache. Proxy needs to check HTTP cache control directives when pulling remote artifacts.
Artipie Maven proxy should use cache directives as well to avoid redundant downloads.

Configuration

The suggested configuration for proxy repository for Artipie is:

repository:
  type: maven-proxy
  remotes:
    - url: https://private.repo.com/maven # required
      username: admin # optional
      password: qwerty # optional
      cache: # optional
        ttl: 5d # optional
        maxSize: 10G # optional
    - url: https://repo.maven.apache.org/maven2

This job may be discussed and changed, also it can be boosted if needed.

README.md has leftovers from previous implementations which does not apply to current project structure. We need to do a cleanup, removing or correcting the following items:

• "maven-adapter": correct project description, it does not depends on 'org.apache.maven' and 'org.eclipse.aether' anymore
• "how it works": we have some documentation on how maven works in "files" and "layout" topics, maybe we could leave them here for documentation purposes
• "a developer's entrypoint": "storaqge lifecycle" topic is outdated and could be removed
• "maven library abstract": is outdated and can be removed also