Comments (7)
The reason is zero-config discovery of plugins, i.e. as a user you just need to add the name of the plugin + its settings to your test script, and Artillery will know how to load it.
Can you give a bit more detail on why that doesn't work for private plugins?
from artillery-core.
We package our custom packages in scopes/namespaces, e.g. @organization_name/package_name because there could be a clashing name in some of our registered repositories.
Enforcing the prefix "artillery-plugin-" suggests there would be a universal distinct list of package names which is not always the case, take an example with artillery on github, its https://github.com/shoreditch-ops/artillery instead of https://github.com/artillery because many people/namespaces can have the same name.
I need to be sure at all times that when I run npm install, my custom package will be loaded.
I suggest the code below just read the plugin name as provided
...
let requireString = 'artillery-plugin-' + pluginName;
let Plugin, plugin;
try {
Plugin = require(requireString);
...
I am happy to submit a pull request for this change.
from artillery-core.
Cool. Will gladly accept a PR which allows something like:
config:
plugins:
some-custom-plugin:
package: "@prefix/some-package-name"
option1: "something"
option2: "somethingElse"
scenarios:
# ...
To load the plugin from @prefix/some-package-name
rather than artillery-plugin-some-custom-plugin
.
from artillery-core.
I don't seem to have write access to this repo, I was trying to push a branch
from artillery-core.
You need to fork and send a pull request.
On Friday, 28 October 2016, Treasure Mathala [email protected]
wrote:
I don't seem to have write access to this repo, I was trying to push a
branch—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#108 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF0qV1aauUAnSzaIT2wsnzKcFDrbu1ks5q4bcAgaJpZM4KiXys
.
from artillery-core.
pull request:
#109
from artillery-core.
Two things to do before we can close this:
- make the trailing slash in the
scope
attribute optional - document the change
from artillery-core.
Related Issues (20)
- Feature Proposal: File Upload HOT 6
- Artillery does not return with certain malformed requests
- Artillery is connecting twice with socket.io HOT 14
- Known vulnerability in npm dependancy ws. HOT 2
- Known vulnerability in npm dependancy tough-cookie
- Question/bug?: customStats being overwritten HOT 1
- beforeReqeust's requestParams can't be customized. HOT 1
- Send binary packet through WS? HOT 1
- WS get received data? HOT 1
- Add socketio query param on connect event HOT 3
- Match json fails for numeric value
- Variables with 0 numeric value are always empty string
- Expose http response body to afterResponse HOT 2
- Socket.IO Engine - Emit Callback Data HOT 1
- Double send in socket.io engine HOT 3
- Add raw TCP socket engine
- [Feature Request] Add support for SignalR
- supporting multipart form data HOT 4
- Data got emit twice in socket.io engine HOT 2
- form not sending data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artillery-core.