Artillery is connecting twice with socket.io about artillery-core HOT 14 CLOSED

Fixed in master, new release on its way.

from artillery-core.

Sounds like a bug @BerendWeij! Thanks for the report!

from artillery-core.

Weird thing. If you add:

socketio:
      query: 'token={"key":value}'

you will see the query being part of the second handshake, and not the first.

from artillery-core.

Commenting on my own issue, nice :)

I think it has to do with the methods:

• loadContextSocket (which adds the query to the options)

• compile (which does not add the query to the options)

They both have a io.connect()

from artillery-core.

The issue with the query object is solved with this pull request: #170

The double connecting is still occurring unfortunately.

from artillery-core.

I think it is an issue with the namespace.
In the method loadContextSocket, there is a lookup
if(!context.sockets[namespace]) {
If it cannot find a socket, it creates a new one. Which should not be the case with my example code.

from artillery-core.

@hassy what would be the easiest way to test changes to artillery-core? I am willing to dive into this issue today when possible. I can find information about the contribution rules, but not about the installation steps.
Best regards!

from artillery-core.

@BerendWeij clone artillery and artillery-core repos, then point lib/dispatcher.js (https://github.com/shoreditch-ops/artillery/blob/master/lib/dispatcher.js) to your local artillery-core, npm install in both directories, and you're good to go!

from artillery-core.

and thanks for taking a look!

from artillery-core.

Awesome! Thanks for the quick reply. I will keep you posted.

from artillery-core.

Any news on this? I'm using artillery 1.6.0-4 and am facing issues with the client connecting twice. This seems to happen only if I define an emit inside of the flow block. Example below:

{
  "config": {
    "target": "http://localhost:3000",
    "phases": [
      {
        "duration": 1,
        "arrivalRate": 1
      }
    ]
  },
  "scenarios": [
    {
      "engine": "socketio",
      "flow": [
        {
          "emit": {
            "channel": "client-loaded"
          }
        }
      ]
    }
  ]
}

This means that if I remove the json object literal inside of flow I get one connection only.

from artillery-core.

there's a problem with this fix.
if you only want to connect and not send anything, it won't connect.

from artillery-core.

Yep, cheers @roeycohen.

from artillery-core.

@hassy, but what if i only want to listen?

from artillery-core.