artificialqualia / dotlan-radar-chrome-extension Goto Github PK

DOTLAN has special faction warzone maps that include all of the warzone systems. Right now if you activate tracking while on one of those maps, the page will get reloaded to a region-specific map instead. It'd be nice for FW folk if radar would continue to use the faction warfare map if already on it.

This plugin is great if you only have one Dotlan tab open but if you try to use another Dotlan tab, say to look at the map one region over, the plugin forces you out of whichever view you're in and dumps you into the tracking view no matter what. Worse, if you already have another map tab open, you can end up losing your state because you're pulled out of whatever you're already doing, say planning a capital jump route.

It would be really nice to have tracking active on a per-tab basis instead of globally across the whole brower. It would be even better if navigating to a new place in Dotlan automatically disabled tracking until it was manually turned back on.

Hi!

First I'd like to say thanks for this wonderful Extension (only wish would be a Firefox version!). However the usefulness have diminished due to a recent update.

In #2 / d5cf476 you added Multi-tab support, which is great in theory. But it overwrites the selected Map Info Layer URI fragments.

For example if I'm in 1DQ1-A and select NPC, I'll get the URL: https://evemaps.dotlan.net/map/Delve/1DQ1-A#npc
Now if I jump into another system, it'll be replaced by for example: https://evemaps.dotlan.net/system/8WA-Z6#?tracking

Was this really intended...?

References:
https://tools.ietf.org/html/rfc3986#section-3.5

When I start tracking, the system name is in a language other than English.

Maybe change it this way and see how it goes.

DOTLAN-Radar-Chrome-Extension/app/scripts/tracker.js
before
url: 'https://esi.evetech.net/latest/universe/regions/'+response.data['region_id']+'/'
after
url: 'https://esi.evetech.net/latest/universe/regions/'+response.data['region_id']+'/?language=en'

The clientID and secret are exposed in code in your app. These should always be kept secret else your tokens can be leaked and abused, or someone could abuse the API on your behalf causing your app to become banned by ccp.

In this case, the user should register their own app, and use their own clientid and secret and not a shared one.

https://github.com/ArtificialQualia/DOTLAN-Radar-Chrome-Extension/blob/master/app/scripts/tracker.js#L167

In the latest patch setting waypoints stopped working with ESI Radar.