Git Product home page Git Product logo

fga-preview's People

Contributors

arthurkun21 avatar binga288 avatar dependabot[bot] avatar echoscrip avatar endo613 avatar fa-gray avatar item4 avatar jcdeoferio avatar kobata avatar lineeee217 avatar mathewsachin avatar metlee avatar minhducsun2002 avatar patwakeem avatar potchy avatar reconman avatar renovate-bot avatar renovate[bot] avatar scathachskadi avatar shineburst avatar squaresmile avatar the3dsandwich avatar

Stargazers

avatar

fga-preview's Issues

Tea pots per battle config

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Tea pots per battle config

  • Check if the ON/OFF exist.
  • Toggle until the desired state is on.
  • On the repeat screen, there is another toggle there to turn it on/off

Use the same storage for the battle configs

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

When starting the app, check the storage and then compare it with the ones on cache.

  • If there needs some updating then it will update the ones on the cache
  • If the one on storage got deleted. just add some mark that it was deleted and just ask if you want to backup again.
  • maybe add some automatic backup I guess if got time

Empty Battle Config List throws Error when creating a new one

Preparation

FGO server

NA

FGA build number

Latest

Describe the bug

Steps to reproduce.

  1. Start a newly installed app
  2. Go to Battle Configs
  3. See that it has no battle configs
  4. Click Add Battle Configs
  5. Crash
java.lang.IllegalArgumentException: Key "cf5535d0-ee29-4a91-b00c-f5e1d6b8c000" was already used. If you are using LazyColumn/Row please make sure you provide a unique key for each item.

Video

No response

Device model

No response

Android version

11

Screen size

No response

RAM

No response

Early Support Refresh

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Check the scrollbar at the support screen. If it doesn't exist, then do a refresh.

  • Track the time since last refresh.
  • Check the scrollbar
    • If it doesn't exist, then check the time since last refresh.
      • If more than 10 seconds have elapsed. then refresh.
      • Otherwise, wait the difference.

Update the Battle Config List Screen

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

  • Unable to fill out the height with using the Card or ListItem. Maybe SubcomposeLayout might worked for LazyVerticalGrid
  • Switched to using the bottom app bar for the export or delete selected
  • Moved the FAB back to its own placed below even in Tablet.

Add the number of runs completed on the play button

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Instead of play button, it would show the number of runs completed. it would make it easier to check how many runs you have already one without pausing the battle config

Wrong read of skill

Preparation

FGO server

NA

FGA build number

197

Describe the bug

Skill 2 is being read as Lvl. 37

skill

Video

No response

Device model

No response

Android version

11

Screen size

No response

RAM

No response

Soujuurou

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Handle New Welfare Servant Special Skill 3

Soujuurou

Critical stars!

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Detect the crit stars

Memory Leak

Preparation

FGO server

NA, JP

FGA build number

Latest

Describe the bug

┬───
│ GC Root: Global variable in native code
│
├─ android.accessibilityservice.
│  AccessibilityService$IAccessibilityServiceClientWrapper instance
│    Leaking: UNKNOWN
│    Retaining 2.3 kB in 28 objects
│    ↓ AccessibilityService$IAccessibilityServiceClientWrapper.mCallback
│                                                              ~~~~~~~~~
├─ android.accessibilityservice.AccessibilityService$2 instance
│    Leaking: UNKNOWN
│    Retaining 1.7 kB in 25 objects
│    Anonymous class implementing android.accessibilityservice.
│    AccessibilityService$Callbacks
│    this$0 instance of io.github.fate_grand_automata.accessibility.
│    TapperService
│    ↓ AccessibilityService$2.this$0
│                             ~~~~~~
╰→ io.github.fate_grand_automata.accessibility.TapperService instance
​     Leaking: YES (ObjectWatcher was watching this because io.github.
​     fate_grand_automata.accessibility.TapperService received
​     Service#onDestroy() callback and Service not held by ActivityThread)
​     Retaining 1.7 kB in 24 objects
​     key = f090b55f-252b-46bf-9cd2-dd071b0aeba9
​     watchDurationMillis = 14225
​     retainedDurationMillis = 9224
​     mApplication instance of io.github.fate_grand_automata.util.
​     AutomataApplication
​     mBase instance of android.app.ContextImpl

METADATA

Build.VERSION.SDK_INT: 30
Build.MANUFACTURER: samsung
LeakCanary version: 2.14
App process name: io.github.fate_grand_automata.canary
Class count: 24123
Instance count: 143589
Primitive array count: 103488
Object array count: 25811
Thread count: 22
Heap total bytes: 22585547
Bitmap count: 11
Bitmap total bytes: 18735
Large bitmap count: 0
Large bitmap total bytes: 0
Db 1: open /data/user/0/io.github.fate_grand_automata.canary/databases/leaks.db
Stats: LruCache[maxSize=3000,hits=39264,misses=117763,hitRate=25%]
RandomAccess[bytes=5582192,reads=117763,travel=39665440234,range=26204958,size=3
2959022]
Analysis duration: 19439 ms

Video

No response

Device model

No response

Android version

11

Screen size

No response

RAM

No response

Combine Card and Servant Priority

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Option to combine the two to enable for a certain servant with high crit to bypass another servant.

Migrate the support image maker to compose

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

FGA-Preview/app/src/main/java/io/github/fate_grand_automata/runner/ScriptManager.kt

Lines 219 to 228 in 455b293

is SupportImageMaker.ExitException -> {
when (e.reason) {
SupportImageMaker.ExitReason.NotFound -> {
val msg = context.getString(R.string.support_img_maker_not_found)
messages.notify(msg)
messageBox.show(scriptExitedString, msg)
}
SupportImageMaker.ExitReason.Success -> showSupportImageNamer(context, storageProvider)

FGA-Preview/app/src/main/java/io/github/fate_grand_automata/ui/support_img_namer/SupportImageNamer.kt

Lines 79 to 110 in 455b293

suspend fun showSupportImageNamer(context: Context, storageProvider: StorageProvider) = withContext(Dispatchers.Main) {
val themedContext = context.dayNightThemed()
val frame = FrameLayout(themedContext)
val inflater = LayoutInflater.from(themedContext)
inflater.inflate(R.layout.support_img_namer, frame)
val content = ScrollView(themedContext).apply {
addView(frame)
setPadding(72, 20, 0, 0)
}
val entryList = getSupportEntries(frame, storageProvider)
suspendCancellableCoroutine { coroutine ->
showOverlayDialog(context) {
setCancelable(false)
.setTitle(context.getString(R.string.support_img_namer_title))
.setView(content)
.setPositiveButton(context.getString(R.string.support_img_namer_done)) { dialog, _ ->
if (entryList.all { it.isValid() }) {
if (entryList.all { it.rename(storageProvider) }) {
dialog.dismiss()
}
}
}
.setNegativeButton(android.R.string.cancel) { dialog, _ -> dialog.dismiss() }
.setOnDismissListener {
coroutine.resume(Unit)
}
}
}

NP Level recognition

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Instead of using OCR, make use of image matching and have the users manually create template per NP Level

Select the wave/turn to start the script

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

add ability to control on what part of the script it would start the autobattle script

Different Script per support

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

Can change script depending on the support selected

Delete log on startup for non-debug builds

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

To save space, delete logs before starting the application

Aoko Skill Launcher bug problem

Preparation

FGO server

JP

FGA build number

Latest

Describe the bug

Aoko skill upgrade screen have the UI to shift down causing the detection to fail

aoko-skill

Video

No response

Device model

No response

Android version

11

Screen size

No response

RAM

No response

On battle config pause, show the remaining commands.

Preparation

  • No one has asked for this feature before in other issues (even the closed ones)

Describe the feature

When the tracking waves and/or turns of commands is finish. Add the ability to display the remaining commands.

Remove the "Ran out of storm pods" Error

Preparation

FGO server

JP

FGA build number

38

Describe the bug

When doing the Strengthening quest in JP, clicking the middle screen would be make it Ran out of pods

Change it to return to the Menu

Video

No response

Device model

No response

Android version

11

Screen size

No response

RAM

No response

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.