arthurhd / immosheets Goto Github PK

• Setting up pytest
• Automatic runs inside GitHub Actions after each commits on every branch
• Coverage reports

We need to properly migrate from V1. The optional field system is broken.

pydantic_core._pydantic_core.ValidationError: 8 validation errors for SelogerSearchQuery
minimumPrice
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing
maximumFloor
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing
minimumFloor
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing
maximumLivingArea
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing
minimumLivingArea
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing
bedrooms
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing
rooms
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing
districtIds
  Field required [type=missing, input_value={'maximumPrice': '800', '...s': '1', 'sortBy': '10'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.0.3/v/missing

Create a generic and simple to use DTO and integrate with third party services thanks to feature flipping.

• Export token creation from Service Auth
• Use console scripts to generate token.json

When checking the link to the Rapidapi site (https://rapidapi.com/apidojo/api/seloger/) the seloger api seems to not exist anymore? When searching on Rapidapi I only get a Selogimmo API call.

• Url parameters are correctly generated
• Validatiors works
• Type validation

Hi,

Thanks for your API.

I do not understand, I am putting zip_codes but I still have this error using SeLogerSearchQuery:

Field required [type=missing, input_value={'zip_codes': '75001', 'm...': None, 'sortBy': None}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.0.3/v/missing

Has it happened to somebody? If yes how can I resolve it?

Thanks!

Raphaël

• Service
• SearchQuery DTO
• SearchQueryFilter

We need to know how the API works in order to retrieve expected results.

Determine which licence suits the best.

pydantic recently passed the version 2, and google librairies needs to be updated too.

• Service
• SearchQuery DTO
• SearchQueryFilter

We need to know how the API works in order to retrieve expected results.

Hey @arthuRHD

I am a beginner here and came across this repository while searching for issues labelled documentation.

I think that by aligning the logo and the tagline, badges to the center - the README.md would look better

I also would like to add a description paragraph for the project.

If you are ok with the above suggestions, could you assign me to the issue and let me work on the README.md?

Regards!!!

https://www.mkdocs.org/user-guide/deploying-your-docs/

We need to move the CNAME file inside the docs folder.

Leboncoin website is not scrapable and immosheets does not use its API.

Hi @arthuRHD ! First of all thank you for your hard work on this python module :)

I played a bit with the module installed via pip and noticed that the BaseModel of the RealEstate is not meant to be overriden, which may be problematic if someone wants to export a different columns structures into google sheets.

For example I personnally don't want to export the emails and contacts of the professionals who listed the Real Estates into google sheets, and it is not possible to modify this behaviour.

Are you planning to openthe model for further inheritances using the module ?

Regards.
Mattecoco

https://gist.github.com/shashankrnr32/c4e68520b46b2a3fea6f933cac4159ca

We should add documentation regarding attributes too. For example specify that the device is in € for maximumPrice.

• Reading correctly the settings
• Results mapper validation

• Service
• SearchQuery DTO
• SearchQueryFilter

We need to know how the API works in order to retrieve expected results.

This project needs contributing rules to prevent anarchy if more people come to contribute.

Here's the list of things that should be done:

• Add a CONTRIBUTE.md file that describes how to make a PR and stuff
• #61
• Provides more information on how to use the project as a developer

• Add MKdocs inside the project
• Host the documentation with github pages
• Add a CI workflow for the documentation
• Give basic examples of what we can do with immosheets
• Migrate functional documentation from README to the website
• Explain how to generate token from many integrations
• Explain how this library can be implemented inside Auto-GPT