artemyb / feliz.materialui Goto Github PK

Hi!

Thank you for making this fork, so far everything is working great. 👍

I am curious what and how much work is required to create the Emotion bindings?

Hi,
I am glad this Feliz.MaterialUI project is alive again.
However for me it was big luck that I found this fork. It would be much better if the changes would be merged back in https://github.com/Shmew/Feliz.MaterialUI

Additionally the current situation that there is no package that can be easily installed is quite frustrating. See #3

Since https://github.com/Shmew/Feliz.MaterialUI is currently inactive, and since I find it confusing when the URL of the repo changes each time the owner changes, I would suggest that somebody creates a github company to host the Felitz.MaterialUI repository.

Since @Shmew is not maintaining the project currently, maybe you can ask him if you can take over the repository. Even if you do not plan to contribute further, it would be good to have somebody that could accept or reject occasional merge requests.

@Linschlager - mentioned because he did the Material UI 5 upgrade for this repository.

Probably the type should have box' name generated instead, like it is done in case of conflicts with keywords (e.g. open' for open prop). Or box name could be kept, but in that case to use the box operator it should be imported explicitly (e.g. to define let box = FSharp.Core.Operators.box before usage). However in Fable !! operator could be used instead, so the problem seems minor.

Hi,

thanks for improving the Feliz.MaterialUI project.

I have added <add key="github" value="https://nuget.pkg.github.com/ArtemyB/index.json" /> to NuGet.config.
When I run dotnet add package Feliz.MaterialUI --version 5.11.0-beta.2 I get the following error

log  : Retrying 'FindPackagesByIdAsync' for source 'https://nuget.pkg.github.com/ArtemyB/download/feliz.materialui/index.json'.
log  : Response status code does not indicate success: 401 (Unauthorized).
info :   GET https://nuget.pkg.github.com/ArtemyB/download/feliz.materialui/index.json
warn : Your request could not be authenticated by the GitHub Packages service. Please ensure your access token is valid and has the appropriate scopes configured.
info :   Unauthorized https://nuget.pkg.github.com/ArtemyB/download/feliz.materialui/index.json 648ms
error: NU1301: Failed to retrieve information about 'Feliz.MaterialUI' from remote source 'https://nuget.pkg.github.com/ArtemyB/download/feliz.materialui/index.json'.

David

The correct signature for MUI v5 is the following (from the MUI docs):

function(props: object, option: T, state: object) => ReactNode

• props: The props to apply on the li element.
• option: The option to render.
• state: The state of the component.

However the current Feliz.MaterialUI prop-binding has only 2 parameters (in MUI v4 there were only option and state parameters).

The new props parameter should be passed to the renderOption's output li-element to ensure that Autocomplete works correctly. Found this explanation in this SO-answer.