Comments (5)
Feels like to me you're lacking a release process. If you want to pin a piece of software to this API version create a branch with a version name and pin your down stream software to that release while you move master
forward.
from libart.
@kellabyte Yep, that was definitely an API mistake. In retrospect, it should have returned the old value via an inout argument and returned an int status code, but ship has sailed... If you call art_insert
on an existing key it will overwrite!
from libart.
Ship has sailed? The API is frozen forever? I might have to second guess using this library if improvements are frozen for good like that.
from libart.
@kellabyte there is downstream code that would break if the function signature is changed, and I prefer to maintain backwards compatibility where possible. Another variant of art_insert could have a different type signature however.
from libart.
@kellabyte that is fair. This project has effectively had a single release so I haven't invested time building a release project. It's not my intention to be difficult, but I don't have the time to maintain this full time. If you find it useful as is that's great, otherwise I hope you can either learn from it or fork and adapt it to your use case.
from libart.
Related Issues (20)
- Does the 52 bytes means extra space used besides the key's space? HOT 1
- Serialization HOT 1
- prefix_mismatch not considering partial_len on longer partial HOT 1
- Serializing the tree HOT 1
- destroy_node() case NODE48, not handled properly HOT 7
- Eliminate implicit padding in art_node struct HOT 1
- Crash in recursive_insert
- Node Header: MAX_PREFIX_LEN & uint8_t num_children HOT 2
- Possible to do range scans with ART ?
- art_iter_prefix depth goes over key_len
- [BUG] key_len not work with longer key
- Range scan performance
- Tag pointers to avoid node type byte HOT 1
- please review SSE instructions HOT 1
- Integer keys need byte-ordering swap?
- If libart support longest prefix match ?
- bugs for art_insert in some case HOT 1
- Is it thread safe? HOT 7
- search get null when str2 = str1 + '\0'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libart.