arm-software / bbr-acs Goto Github PK

Remove SCT SMBIOS tests as they are already covered by FWTS.

https://github.com/ARM-software/bbr-acs/blob/44943eb3fd239fde1002107568b0a5f154949f7f/common/sct-tests/sbbr-tests/SbbrSmbios/BlackBoxTest/SbbrSmbiosBBTestFunction.c

looks like some patch fail:
...

Ran 285 tests in 0.561s

OK
make[1]: Leaving directory '/home/yin/c/acs/bbr-acs/ebbr/scripts/edk2/BaseTools/Tests'
make: Leaving directory '/home/yin/c/acs/bbr-acs/ebbr/scripts/edk2/BaseTools'
1 out of 1 hunk FAILED
3 out of 3 hunks FAILED
1 out of 1 hunk FAILED
6 out of 6 hunks FAILED
1 out of 1 hunk FAILED
1 out of 1 hunk FAILED
2 out of 2 hunks FAILED
1 out of 1 hunk FAILED
1 out of 2 hunks FAILED
1 out of 1 hunk FAILED
1 out of 1 hunk FAILED
1 out of 1 hunk FAILED
Applying SCT patch ...
patching file uefi-sct/SctPkg/CommonGenFramework.sh
patching file uefi-sct/SctPkg/Config/Data/Category.ini
patching file uefi-sct/SctPkg/Library/SctGuidLib/SctGuidLib.inf
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/ImageBBTestConformance.c
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/ImageBBTestFunction.c
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/Misc.h
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestConformance.c
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestMain.c
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Dependency/Config/EfiCompliant.ini
patching file uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c
Hunk #1 FAILED at 291.
1 out of 1 hunk FAILED -- saving rejects to file uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c.rej
patching file uefi-sct/SctPkg/TestInfrastructure/SCT/Drivers/StandardTest/StandardTest.c

Build failed: error while running do_build at line 157 in ./build-scripts/build-sct.sh for [][].

SimpleFileSystemProtocolTest and BlockIOProtocolTest are missing in EBBR.seq though they are required by the EBBR:

EFI_BLOCK_IO_PROTOCOL           | Required for block device access
EFI_SIMPLE_FILE_SYSTEM_PROTOCOL | Required if booting from block device is supported

In the SCT test, we get an error “BS.AllocatePool - Type is EfiMaxMemoryType – FAILURE 99F47EDE-57C9-4892-943E-F0F508B23B91”.
We believe that the test should be compiled against a newer stable tag to pull tianocore/edk2@502c01c.

BS.AllocatePool - Type is EfiMaxMemoryType -- FAILURE
99F47EDE-57C9-4892-943E-F0F508B23B91
/home/marc/devel/ampere/arm-systemready/SR/scripts/edk2-test/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/BlackBoxTest/MemoryAllocationServicesBBTestConformance.c:953:Status - Success

On some virtual environments, the following error is observed:

ERROR: Cannot do the operations. Status - Out of Resources

The issue results from an empty \EFI\BOOT\bbr\SCT\Data\TestCase.ini file, which causes the SCT to display the Out of Resources error and immediately exit. TestCase.ini is normally populated with data about the test cases that are supposed to be run.

When the file is first zeroed out, SCT hangs with no error message.

The following triggers the issue::

1. Run the SBBRRuntimeServicesBBTestFunction test (GUID E8C528DE-4B69-4C6B-AAEC-69645969266F) see code

2. After completion, SCT calls SaveTestCases() (within ContinueExecuteStart() since the NVRAM test cold resets halfway through execution).

3. Within SaveTestCases(), EfiIniFlush() is called. TestCase.ini appears to be zereod out inside this function, specifically line 1356. This line writes to the EFI_FILE_HANDLE provided as an argument to the function, which is presumably TestCase.ini.

The relation between the SBBRRuntimeServicesBBTestFunction test and TestCase.ini being zeroed out is unclear. ACS automatically runs to completion when the SBBRRuntimeServicesBBTestFunction test is excluded. When the SBBRRuntimeServicesBBTestFunction test is run on its own, it succeeds, then SCT hangs.

command:
bbr-acs/sbbr/scripts$ ./build-scripts/build_sbbr.sh
output log:
....
gcc -c -I ./brotli/c/include -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I-I . -I ../Include/X64/ -MD -fshort-wchar -fno-strict-aliasing -fwrapv -fno-delete-null-pointer-checks -Weprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g -O2 brotlic -o brotli/c/dec/bit_reader.o
gcc -c -I ./brotli/c/include -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I-I . -I ../Include/X64/ -MD -fshort-wchar -fno-strict-aliasing -fwrapv -fno-delete-null-pointer-checks -Weprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g -O2 brotli brotli/c/dec/decode.o
brotli/c/dec/decode.c:2033:41: error: argument 2 of type ‘const uint8_t ’ {aka ‘const unsigned char ’} ter [-Werror=vla-parameter]
2033 | size_t encoded_size, const uint8_t encoded_buffer, size_t decoded_size,
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
In file included from brotli/c/dec/decode.c:7:
./brotli/c/include/brotli/decode.h:204:19: note: previously declared as a variable length array ‘const uie]’ {aka ‘const unsigned char[*decoded_size]’}
204 | const uint8_t encoded_buffer[BROTLI_ARRAY_PARAM(encoded_size)],
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
brotli/c/dec/decode.c:2034:14: error: argument 4 of type ‘uint8_t *’ {aka ‘unsigned char ’} declared as =vla-parameter]
2034 | uint8_t decoded_buffer) {
| ~~~~~~~~~^~~~~~~~~~~~~~
In file included from brotli/c/dec/decode.c:7:
./brotli/c/include/brotli/decode.h:206:13: note: previously declared as a variable length array ‘uint8_t[a ‘unsigned char[encoded_size]’}
206 | uint8_t decoded_buffer[BROTLI_ARRAY_PARAM(*decoded_size)]);
| ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [../Makefiles/footer.makefile:21: brotli/c/dec/decode.o] Error 1
make[2]: Leaving directory '/home/yin/c/acs/bbr-acs/sbbr/scripts/edk2/BaseTools/Source/C/BrotliCompress'
make[1]: *** [GNUmakefile:76: BrotliCompress] Error 2
make[1]: Leaving directory '/home/yin/c/acs/bbr-acs/sbbr/scripts/edk2/BaseTools/Source/C'
make: *** [GNUmakefile:19: Source/C] Error 2
make: Leaving directory '/home/yin/c/acs/bbr-acs/sbbr/scripts/edk2/BaseTools'

Build failed: error while running do_build at line 134 in ./build-scripts/build-sct.sh for [][].