arendjr / eslint-plugin-no-pipe Goto Github PK

I agree mostly with the spirit of this plugin. I dislike how |> has been designed (and intentionally limited). But I wonder if there aren't some small exceptions where |> might have a bit of merit?

I am curious if you would consider/accept adding an optional (off by default) mode/rule for this plugin, where it doesn't outright disallow |>, but specifically disallows:

• any usage where the topic is bound to preceding simple literal, identifier, or property reference is bound as the topic
• any usage where the topic (%, ^, ^^, or whatever the heck they pick) is used not inside an argument to a call expression

Such a mode would still error on all these absurdities:

42 |> [ 1, 2, % ]

"Hello world" |> console.log(%)

func |> %(42)

tagFn |> %`whatever`

cb |> pr.then(%)

obj.increment |> arr.map(%)

tagFn |> %`whatever`

But the mode would still allow some |> usage, like these:

fortyTwo() | [ 1, 2 ].concat(%)

"Hello world".toUpperCase() |> console.log(%)

(obj.increment ?? identity) |> arr.map(%)

The thinking behind allowing those is:

1. functional composition is still a valid use-case
2. a complex expression in an argument position of a function call can be rather unreadable, so there's potentially some slight benefit in separating the expression from the call-site with the |>.

What do you think?