ardanlabs / gotour Goto Github PK

Context:https://tour.ardanlabs.com/tour/error-handling/1

Link to https://crawshaw.io/blog/xerrors
probably should be replaced with?
https://go.dev/blog/go1.13-errors,
now that it is part of standard library, not a proposal anymore.

Also, maybe https://go.dev/blog/go1.13-errors supersedes https://go.dev/blog/error-handling-and-go ?

Also, the correct link for Why Go's Error Handling is Awesome is:
https://rauljordan.com/why-go-error-handling-is-awesome/

Context: https://tour.ardanlabs.com/tour/eng/functions/2
Instead of declaration (:=) assignment (=)happen at line 38 in answer1.go

// Call the function and just check the error on the return.
_, err = newUser()
if err != nil {
	fmt.Println(err)
	return
}

Hi all 👋 I'd like to see this fantastic tour and course to the Spanish language, and I'd be interested in contributing the translation as a whole.

I have a local branch that could serve as seed for this, and I wonder if it would be of interest to start pushing it as a PR, and review it in small chunks, given there is a lot of content.

What would it be the preferred way of doing this?

Thanks in advance!

Implement a dark mode option in the Ardan Go Tour as in the official Go Tour.

Context: https://tour.ardanlabs.com/tour/functions/1

Typo in extra reading list.

Context: https://tour.ardanlabs.com/tour/eng/interfaces/1

Missing example 9 in the Interfaces section.

Context: https://tour.ardanlabs.com/tour/error-handling/1

Hey im just reading your great tour but u forgot to change from errorf() to wrapf().
At line 67 and 75.

I think this should be:
"Functions can return one or more values (or none, in which case you can omit the
return type)..."

I would like to start a discussion about whether we also change comments in code. My first instinct was to say no. For sure I don't want to touch the actual code.

Translate to Russian "Generics Basics"

@ardan-bkennedy how will the transcription from Ultimate Go Notebook to Go tour website happen? which information is required?

Hey folks, I hope you're all doing well.
I'm interested in providing the translations for the site to Spanish.
Although I'm not very familiar with the tools being used for the site in question (https://tour.ardanlabs.com).

Would you please provide some guidance to get started on this 🙏🏽 ?
Thanks in advance

I think we should agree on a form of PRs for translations. If you look at the current PR list it is very hard to see wherever it is a translation PR and for what language, and I have to see one by one to check if I can either review or contribute..

I am thinking of:

[Translation] [<Language>] : <What are you translating?>

Example:

[Translation] [Spanish]: Binary search article.

Context: https://tour.ardanlabs.com/tour/eng/variables/1

"using a non-precision based type (unit, int) the size of the value is based on the architecture being used to build the program: "
I think it's necessary to change unit to uint.

Declaring and Initializing Values

it is written "This means that each string has the first word set to nil and the second word set to 0."
But, this shouldn't be "This means that each string has the first word set to nil and the second word set to an empty string ("")." ?

I would be up to translating these materials into Russian if you guys are interested.

Let me know
Nicolai

For those who purchased the course, it would be nice to have not just a generic link to "ultimate go bundle", but to the actual video.

E.g. this

Not sure how much work is it to maintain the links though.
But maybe more people will buy the course if they see a link to a relevant video?
Maybe you can also include a short preview for each relevant video, to make people more excited :)

Hello,

would you be interested in a french translation of the Go Tour ?

As I'll start going through for a refresher, I could translate as I go along.

Regards.

Context: https://tour.ardanlabs.com/tour/eng/methods/1

In example2.go, the methods setHours and hours, as they are, ignores any fractional part of hours.

I think they should be as follows:

// setHours sets the specified number of hours.
func (d *duration) setHours(h float64) {
	*d = duration(h*float64(hour))
}

// hours returns the duration as a floating point number of hours.
func (d duration) hours() float64 {
	hours := d / hour
	nsec := d % hour
	return float64(hours) + float64(nsec)*(1e-9/60/60)
}

Thank you for a wonderful resource.

To reproduce:

1. Visit https://tour.ardanlabs.com/tour/list;
2. The icons in the header are misaligned when visiting the tour on the phone;

4. Not showing the title:

Issue

I encountered an issue while trying to install the github.com/ardanlabs/gotour/cmd/tour package using Go version go1.21.1. Below is the error message I received:

# runtime/internal/sys
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:9:7: len8tab redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:76:7: other declaration of len8tab
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:32:6: Len64 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:99:6: other declaration of Len64
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:50:7: m0 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:117:7: other declaration of m0
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:51:7: m1 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:118:7: other declaration of m1
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:52:7: m2 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:119:7: other declaration of m2
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:55:6: OnesCount64 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:122:6: other declaration of OnesCount64
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:86:6: LeadingZeros64 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:153:6: other declaration of LeadingZeros64
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:89:6: LeadingZeros8 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:156:6: other declaration of LeadingZeros8
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:92:6: Len8 redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:159:6: other declaration of Len8
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:101:6: Prefetch redeclared in this block
	/usr/local/go/src/runtime/internal/sys/intrinsics.go:200:6: other declaration of Prefetch
/usr/local/go/src/runtime/internal/sys/intrinsics_common.go:101:6: too many errors

Environment

• Go version: go1.21.1
• Operating System: Linux (amd64)

Steps to Reproduce

1. Run the following command: go install github.com/ardanlabs/gotour/cmd/tour@latest

Expected Behavior

I expected the github.com/ardanlabs/gotour/cmd/tour package to be installed without any errors.

Actual Behavior

The installation process failed with the error mentioned above.

Additional Information

Please let me know if you need any additional information to diagnose and fix this issue.

Thank you!

rand.Seed is deprecated and not needed anymore: https://pkg.go.dev/math/rand#Seed

Should it be removed everywhere?
https://sourcegraph.com/search?q=context:global+rand.Seed+repo:github.com/ardanlabs/gotour&patternType=standard&sm=1&groupBy=repo

Also, there is probably some linter in golangci-lint that alerts about usage of deprecated functions. Should it be enabled, to catch stuff like this automatically?

Context: https://tour.ardanlabs.com/tour/rus/variables/1

I think it's necessary to replace "(unit...)" to "(uint...)"

"Когда вы объявляете тип данных без указания точности (unit, int), размер выделяемой памяти зависит от архитектуры компьютера на котором происходит сборка программы:"

@ardan-bkennedy I wonder if it's possible to merge a language branch without making it public, so that the changes in the core are applied to that WIP language when they are introduced. Otherwise, we have to go resolving conflicts and keeping track of the changes manually trying not to forget any of them. You know, manually resolving conflicts could lead to mistakes.

Originally posted by @mdelapenya in #239 (comment)