This tool is very useful and I think that add support for multiple namespaces also It's a improvement simple and powerful. If you want I could create a PR with the solution.

Thanks for this helm chart! It is very useful

I suggest to use the AWS account name instead of the ID. It is a detail but in a script, it is more clear to manage an account name

Louis

Hello,

I use HELM version 3.0.3 and I have an issue that makes the chart unusable

My Kubernetes cluster uses the version 1.13.11-gke.23

So this is my script

printf 'Get architectminds/aws-ecr-credential chart.'
# https://hub.helm.sh/charts/architectminds/aws-ecr-credential
helm repo add \
    architectminds \
    https://architectminds.github.io/helm-charts/

printf 'Create base64 AWS credentials.\n'
AWS_ACCESS_KEY_ID=XXX
AWS_SECRET_ACCESS_KEY=XXX
AWS_ACCESS_KEY_ID=$(echo ${AWS_ACCESS_KEY_ID} | base64)
AWS_SECRET_ACCESS_KEY=$(echo ${AWS_SECRET_ACCESS_KEY} | base64)

printf 'Deploy architectminds/aws-ecr-credential chart.'
helm upgrade aws-ecr-credential \
    --install --force \
    --set-string aws.account="${AWS_ACCOUNT_ID}" \
    --set aws.region="${AWS_ECR_REGION}" \
    --set aws.accessKeyId="${AWS_ACCESS_KEY_ID}" \
    --set aws.secretAccessKey="${AWS_SECRET_ACCESS_KEY}" \
    --set targetNamespace=default \
    architectminds/aws-ecr-credential

And the log of the Kubernetes job:

We can see that we have an unexpected line break after all string variables

I think the issue is a format issue regarding this log
Invalid header value b'AWS4-HMAC-SHA256 Credential=XXX\n/20200204/eu-west-1/ecr/aws4_request, SignedHeaders=content-type;host;x-amz-date;x-amz-target, Signature=0ceab1d4c0712bb7c40bb49565426faa129dd0ca9ef5ee7e4923f16a5e1a0a8a'

Can I have help on this issue please? Maybe I did something wrong. It is possible to be a bug in the chart

Thank you in advance

Hi, I would like to report a strange behaviour of the project - cannot install that on Rancher kubernetes cluster.

Everytime I try to install it, it reports with an error:
Wait helm template failed. Error: stat /aws-ecr-credential: no such file or directory : exit status 1

Rancher version: 2.2.8

This is a neat tool, which could avoid needing NodeInstanceRole on EKS nodes for pulling from an ECR registry.

It would be more-useful for this if it supported IAM Roles for Service Accounts, specifically:

• supporting adding annotations to the generated Service Account (which makes the accessKeyId and secretAccessKey optional)
• for eksctl users, supporting a pre-created Service Account that already has all the right permissions.

It would also be useful in this case to document the necessary permissions for the Service Account.

Probably not a high-priority feature, I'm not sure if avoiding NodeInstanceRole is actually valuable. I guess this could also be leveraged for access to cross-account ECR instances, i.e. not covered by the default NodeInstanceRole, if that's an interesting use-case.

With reference to the schedule in

Should it be something "0 */8 * * *" instead?