Git Product home page Git Product logo

larks's Introduction

larks's People

Contributors

lanrayy avatar r-a-01 avatar archie-adams avatar sc21ar avatar sc21nl avatar sc20sh avatar kbraszkiewicz avatar marilenamanoli avatar jefferyt343 avatar

Watchers

 avatar

larks's Issues

Get the code running

Each member of the team gets the code running on their systems by the end of sprint 1

  • Archie
  • Natalie
  • Jeffery
  • Ayesha
  • Marilena

Login error handling

  • The error messages for incorrect password isn't correctly displayed on wrong email/password.
  • on signup page, 'Already have an account' leads to '/login' it should lead to '/signin'.

frontend has loads of useless imports

  • We need to add ESLint to the project and fix these to improve code quality
  • Once this is done we need to add the linter to our CI/CD / PR pipeline so no more warnings get into main

Urls in routes.tsx could be hierarchical

In react router v6 something like this could become

<Route path="/dipstik" element={<DipstikInstructions />} />
<Route path="/dipstik/dipstik-timer" element={<DipstikTimer />} />
<Route path="/dipstik/dipstik-camera" element={<DipstikCamera />} />
<Route path="/dipstik/dipstik-results" element={<DipstikResults />} />

Something like

<Route path="/dipstik" element={<Outlet/>} />
      <Route path="/" element={<DipstikInstructions />} />
      <Route path="/dipstik-timer" element={<DipstikTimer />} />
      <Route path="/dipstik-camera" element={<DipstikCamera />} />
      <Route path="/dipstik-results" element={<DipstikResults />} />
</route>

for better DRY

Sort out how we want to use git

The last repository did a pretty bad job with repo management.

As a team we should get together and think about:

  • Deleting branches after PR's (no confusing hanging branches by the end of it)
  • Branch naming conventions
  • Code quality and testing checks required for PR pass
  • atomic commits
  • commit messages

just basic stuff we ought to be on the same page with

Header displayed on signin page and login page available when authenticated

In the App.tsx file lines 21-30 'deals' with showing the user a login page when they are not authenticated.

This poor implementation means that the header is now shown always on the signup page, and also means that a user can manually navigate to the loginpage when loggedin, putting the app in an undefined state.

The proper way to deal with this is to define a guarded route component to be used in Routes.tsx for urls only authenticated users can access, which redirects the user to login otherwise.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.