arcavias / arcavias-core Goto Github PK

Please extend the Default and Zend URL view helpers to receive a config array as sixth parameter just like the Typo3 URL view helper in the TYPO3 extension.

Afterwards, fetch the specific configuration for each target before the link is generated in the html client layouts (like in catalog/filter/search-header-default.html).

tow different styles in one method.

https://github.com/Arcavias/arcavias-core/blob/master/controller/frontend/src/Controller/Frontend/Basket/Default.php#L155-L159

https://github.com/Arcavias/arcavias-core/blob/master/controller/frontend/src/Controller/Frontend/Basket/Default.php#L164-L166

PSR say:

if ( condition ) {
    // some code
} elseif ( condition2 ) {
    // some code
} elseif ( condition3 &&
           condition4
) {
    // some code
} else {
    // some code
}

Users would like to be able to undo changes made, like inserting a new item, updating or deleting an existing one. This could be done by implementing a decorator that saves the item record and the operation before it's modified to a "history" table via a manager in the MAdmin name space. The user could then revert changes via a panel in the portal view in combination with a controller restoring the original items and saving them by using the appropriate manager.

All items implement a toArray() method which returns all item properties as array with the same key as used for searching. The same operation should be possible the other way round by handing over an array of properties with the same keys which will be set in the item.

The ExtJS controller for attributes, media, price, product and text implemenet their own deleteItems() method. This method uses getItem() and deleteItem() to fetch and delete records. Instead, searchItems() and deleteItems() of the appropriate managers should be used to speed up deletion of the records.

There should be buttons to cancel, refund, capture and query the payment of an order in the detail view of in the payment tab in the admin interface

On the left side of the picker UIs you can change several values of the list entries like status, type, start and end date. Usability would be improved much if those values could be changed at once for all selected list items.

Consider frameworks like EmberJS

The product category tab contains the list of categories where the product is listed in. It also shows some details of the categories but if more than 100 categories are available, the details for some categories might be missing. The bug is visible if the product is attached to a category which isn't fetched from the backend due to the default slize size of 100.

Please rewrite fetching the categories / catalog items to only retrieve the categories where the product is listed in but without size limit.

It should be possible to add categories from the catalog tree (on the right) to the product. The associated categories should be listed on the left like it is already done with attribute, tags and product tabs.

For the selection attributes in the catalog detail view, shop owners should be able to sort the attribute types according to their needs. For this, we need a new "pos" column in the type tables and the possibility to sort by "attribute.type.position".

The test methods of the catalog index manager test class (and the test sub-classes in the catalog index domain) have very big test methods where several things are tested in one test method.

Please split these test methods into several methods and each method should test only one thing.

To make getItem() more flexible, please add an optional parameter for a criteria object to getItem():

getItem( $id, $ref = array(), MW_Common_Criteria_Interface $search = null )

This criteria object can be then used to add more conditions to limit the found items.