arbaz-softagics / commons Goto Github PK

Hi,

I can't create pull request so I post here.

I'm trying the plugin is working great but it would be create if please give the title and the Okay button to be customizable as I want to put custom text.

Thanks,
Cheng

Can you please make the background of the dialog configurable, or something like that?

For now, it is not respecting custom dark theme, it shows the background as white, no matter what theme is set.

It's a great work, and much appreciate if you guys gets attention on this issue.
As per my knowledge, I am trying to open a dialog with single selection radio button.

This is how i added

isSelected parameter seems not been used in your code!

Hi,

I have recently updated flutter and now i have an exception during compilation :

Compiler message:
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/commons-0.7.6/lib/src/functions/navigation_functions.dart:27:32: Error: This expression has type 'void' and can't be used.
  return Navigator.of(context).pop<T>(result);
                               ^
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/commons-0.7.6/lib/src/functions/navigation_functions.dart:31:32: Error: This expression has type 'void' and can't be used.
  return Navigator.of(context).pop<T>(result);
                               ^

Compiler message:
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/commons-0.7.6/lib/src/functions/navigation_functions.dart:27:32: Error: This expression has type 'void' and can't be used.
  return Navigator.of(context).pop<T>(result);
                               ^
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/commons-0.7.6/lib/src/functions/navigation_functions.dart:31:32: Error: This expression has type 'void' and can't be used.
  return Navigator.of(context).pop<T>(result);
                               ^
Target kernel_snapshot failed: Exception: Errors during snapshot creation: null
build failed.

FAILURE: Build failed with an exception.

* Where:
Script 'C:\src\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 882

* What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.
> Process 'command 'C:\src\flutter\bin\flutter.bat'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 24s
Exception: Gradle task assembleDebug failed with exit code 1

Method "pop()" has changes and now it's return null.

Here is my flutter version :

Flutter 1.17.0-3.2.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 2a7bc389f2 (29 hours ago) • 2020-04-21 20:34:20 -0700
Engine • revision 4c8c31f591
Tools • Dart 2.8.0 (build 2.8.0-dev.20.10)

Thank you.

How can i change the title of buttons such as 'Select all', 'Un-Select All' and 'Done'.

Can you please make a version where I can set a Widget instead of the String message?

dialog( BuildContext context, Color color, String title, String message

How can i change the height of single or multiSelectDialog instead of full screen.

pubspec.yaml:

environment:
sdk: ">=2.6.0 <3.0.0"

dependencies:
flutter:
sdk: flutter

cupertino_icons: ^0.1.2

scoped_model: ^1.0.1

webview_flutter: ^0.3.9

provider: ^4.0.4

web_socket_channel: ^1.0.12

dio: ^3.0.9
json_annotation: ^2.4.0
build_runner: ^1.6.1
json_serializable: ^3.0.0
shared_preferences: ^0.5.6
commons: ^0.7.5
google_nav_bar: ^2.0.0
font_awesome_flutter: '>= 4.7.0'

Pod Install fail

-> Installing share (0.5.2)
-> Installing shared_preferences (0.0.1)
-> Installing shared_preferences_macos (0.0.1)
-> Installing shared_preferences_web (0.0.1)
-> Installing url_launcher (0.0.1)
-> Installing url_launcher_macos (0.0.1)
-> Installing url_launcher_web (0.0.1)
-> Installing webview_flutter (0.0.1)
  - Running pre install hooks
[!] Unable to determine Swift version for the following pods:
- `get_version` does not specify a Swift version and none of the targets (`Runner`) integrating it have the `SWIFT_VERSION` attribute set. Please contact the author or set the `SWIFT_VERSION` attribute in at least one of the targets that integrate this pod.
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.9.1/lib/cocoapods/installer/xcode/target_validator.rb:125:in `verify_swift_pods_swift_version'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.9.1/lib/cocoapods/installer/xcode/target_validator.rb:39:in `validate!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.9.1/lib/cocoapods/installer.rb:590:in `validate_targets'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.9.1/lib/cocoapods/installer.rb:158:in `install!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.9.1/lib/cocoapods/command/install.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.9.1/lib/cocoapods/command.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.9.1/bin/pod:55:in `<top (required)>'
/usr/local/bin/pod:23:in `load'
/usr/local/bin/pod:23:in `<main>'

Error output from CocoaPods:

Could you downgrade the version of SDK to be compatible with dart SDK 2.5.0? thanks

I had upgrade this project to null-safety support. But I had modified the ui of the dialogs. If you don't mind it, you can use :

commons:
    git:
      url: 'https://github.com/Creky/commons.git'
      ref: master

http ^0.13.0 has some breaking changes and dependency version needs to be changed from http ^0.12.1
@Arbaz-Softagics @amirh @ArbazMateen

Hi,

When I create a singleInputDialog and add a value, the value is not set in the textfield - it actually looks like the value is set in the textfield, bit it is being shown as a label or something "behind" the textfield. When I save the dialog the value is emplty unless I enter at new value in the textfield.

singleInputDialog( context, title: "Input Dialog", label: "Name", value: item.optionName, validator: (value) { print("Validator: $value"); return value.isEmpty ? "Required!" : null; }, positiveAction: (value) async { item.optionName = value; await updateOption(item); setState(() {}); print("Submit: $value"); }, negativeAction: () { print("negative action"); }, neutralAction: () { print("neutral action"); }, negativeText: "d", );

The string Check this box for confirmation! is not translatable because the dialog does not expose this string as a parameter.

Unable to use flutter_typeahead plugin along with commons plugin as commons plugin is using older version of flutter_keyboard_visibility.

Error message while doing pub-get:
Short:
commons ^0.7.8+3 is incompatible with flutter_keyboard_visibility_platform_interface >=2.0.0

Detailed:
Because no versions of commons match >0.7.8+3 <0.8.0 and commons 0.7.8+3 depends on url_launcher ^5.4.1, commons ^0.7.8+3 requires url_launcher ^5.4.1.
And because url_launcher >=5.4.1 <5.5.2 depends on url_launcher_platform_interface ^1.0.4 and url_launcher_platform_interface >=1.0.4 <1.0.5 depends on plugin_platform_interface ^1.0.0, commons ^0.7.8+3 requires url_launcher ^5.5.2 or plugin_platform_interface ^1.0.0 or url_launcher_platform_interface ^1.0.5.
And because url_launcher >=5.7.7 <6.0.0-nullsafety depends on url_launcher_platform_interface ^1.0.9 and url_launcher >=5.5.2 <5.7.7 depends on url_launcher_platform_interface ^1.0.8, commons ^0.7.8+3 requires plugin_platform_interface ^1.0.0 or url_launcher_platform_interface ^1.0.5.
And because url_launcher_platform_interface >=1.0.5 <2.0.0-nullsafety depends on plugin_platform_interface ^1.0.1 and flutter_keyboard_visibility_platform_interface >=2.0.0 depends on plugin_platform_interface ^2.0.0, commons ^0.7.8+3 is incompatible with flutter_keyboard_visibility_platform_interface >=2.0.0.
And because flutter_typeahead >=3.1.0 depends on flutter_keyboard_visibility ^5.0.0 which depends on flutter_keyboard_visibility_platform_interface ^2.0.0, commons ^0.7.8+3 is incompatible with flutter_typeahead >=3.1.0.

Thank you for your amazing work!

Can you please allow for us to change the background color of the round circle in the infoDialog et co?

I am talking about this __AlertDialog.INFO <- it's const and hidden :(

commons: ^0.7.8+3 uses old dependencies, please update