In Workspaces application, deny the possibility to create 2 spaces with the same name.
Ex : "Brexit" et "brexit" (to deny)
Ex : "Brexit" et "Brexit" (to deny)

When a user who is not in GeneralManager group, he has a json page and not a web page from Nextcloud.

To test that :

1. First, you connect to our dev platform ;
2. Second, in the users settings, remove me to GeneralManager group ;
3. Third, use impersonate to impersonate me ;
4. Then, click on the Workspace button and look at the result ;

I think the Middleware should return a page template.

Doc : https://docs.nextcloud.com/server/21/developer_manual/basics/middlewares.html.

Originally posted by @zak39 in #22 (comment)

if the user reloads the main page ("All spaces" page), he gets redirected to NC's dashboard

Steps to reproduce

1. open workspace (url is something like https://acme.org/index.php/apps/workspace
2. click on a space to view its details page
3. click on the "All Spaces" button to go back to the application's main page
4. note how the url gets a '/' appended compared to url at step 1 (url is something like https://acme.org/index.php/apps/workspace/
5. refresh the page

Via l'option "renommer un espace projet"

Create a workspace table to list all the workspaces, in NC database

The frontend currently uses 2 routes to do that:

			// Creates group in backend
			axios.post(generateUrl(`/apps/workspace/group/add/${group}`))
				.then((resp) => {
					// Give group access to space
					axios.post(generateUrl(`/apps/groupfolders/folders/${this.$route.params.space}/groups`), { group })
						.then((resp) => {
							// Navigates to the group's details page
							this.$store.state.spaces[this.$route.params.space].isOpen = true
							this.$router.push({
								path: `/group/${this.$route.params.space}/${group}`,
							})
						})
						.catch((e) => {
							// TODO revert frontend change, delete group in backend, inform user
						})
				})
				.catch((e) => {
					this.$store.commit('removeGroupFromSpace', { name: this.$route.params.space, group })
					// TODO Inform user
				})

to be alerted about updates in our dependencies

see https://docs.github.com/en/code-security/supply-chain-security/managing-vulnerabilities-in-your-projects-dependencies/configuring-dependabot-security-updates#managing-dependabot-security-updates-for-your-repositories

It should move the autoComplete() function from PageController for a clean code.

May be SearchController ?

I don't know yet.

Change the logo to the EP application, visible in the Nextcloud application menu, based on feedback from Clementine.

on nc20 today:

{"reqId":"hICpjpuAMYjm3znNHi71","level":0,"time":"2021-06-04T17:33:31+02:00","remoteAddr":"178.51.145.29","user":"admin","app":"user_ldap","method":"PATCH","url":"/apps/workspace/api/space/MonGroupFolder/user/Nicolas%20V%C3%A9rit%C3%A9","message":"No DN found for Nicolas V\u00e9rit\u00e9 on ldaps://test.arawa.fr","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0","version":"20.0.9.1"}

Workspace is based on the current Group Folders app on Nextcloud that manages workspace for joint work

Those workspaces are created by general managers. Simple users only have access to the files.
General managers can assign Workspace managers to handle the workspaces.

In these mockups, the user is a general manager.

Workspace Homepage

The Workspace app's ergonomic design is pretty similar to the Deck app (when using the "All boards" option).
There is a collapsible side menu on the left that lists all the workspaces and their number of users.
The "all workspaces" option shows the same list on the main page with more information : the quota and the managers.

Creating a new Workspace

The creation button at the top of the side menu allows to quickly create a new workspace with a default unlimited quota.

Workspace

Once the manager clicks on a workspace, they get access to the list of members with their names and emails. The roles of each member is specified in the middle column, workspace managers are fixed to the top of the list. The right column indicates the workspace's groups that each member is a part of.

Workspace Settings

Workspace settings allow the manager to rename and delete the workspace, member settings allow to remove a member from the workspace or assign them as workspace manager.

Add members to a workspace

The + button on the top right corner allows the manager to add members or create a new group.
The "add members" option opens a modal with a search bar for users. Once the users are selected, they can be assigned as workspace managers by checking the checkbox.

Create a group

Since a workspace can get crowded, there is a possibility of creating groups within it. The creating process is the same as creating a workspace.

Groups appear on the side menu on the left, below the workspace they're a part of.

Add members to a group

Adding members to a group is exactly the same as adding members to a workspace, apart from the fact that group members cannot be assigned as workspace managers.

We added blue stickers to differentiate workspace's members from generic nextcloud users.
If the manager selects someone who isn't already a member of the workspace, a message will appear, warning that the user will automatically be added to the corresponding workspace.

Group Settings

The group settings are very similar to the workspace's, the only difference is that the manager cannot assign a group member as a workspace manager (they need to be assigned directly in the workspace).

@jancborchardt @juliushaertl What do you think ?

It has to move the autoComplete() function in another controller for more consistent.

I'll do that in another PR if you don't mind. I propose to create an issue for this so that I don't forget.

Possible roles : manager or user

Be able to view the quota for each workspace in the interface for managing a workspace

Be able to modify the quota of a workspace in the interface for managing a workspace

We must find a solution to hide the workspace button in the header and show authorized users only.

We can use the 'limit to groups" app functionnality:

Originally posted by @StCyr in #25 (comment)

Some vue.js reactivity issue: When you add or remove a user from a workspace/group, the user table doesn't update

Steps to reproduce:

In SelectUser:

1. type a few letter to find a user to add to the selection and add it
2. in the list of selected users, click the delete (trash) icon to remove the user
3. see that the user is removed from the list but not from the MultiSelect 'selection at the top of the modal

Non prioritaire, ne pas passer trop de temps (pas pour le sprint 7, à discuter)

Possible roles : manager or user

• add the functionnality add users to subgroups
• add a member sticker on members' avatar when the user doesn't belong to the Workspace
• add red hightlight when the user doesn't belong to the Workspace
• add advertise message
  See mockups : 21 à 24

Always have the same colour of the workspace label, even after reloading the page, on all pages displaying the workspace:

• workspace management interface (a),

• list of workspaces in the left-hand menu (b),

• list of workspaces in the main workspace page (c)

• Give the possibility to choose the workspace color at the creation of the workspace.
  
  

Rank the members of a workspace, so that space managers appear first, sorted alphabetically by Nextcloud name. Then single users appear, also sorted alphabetically by Nextcloud name

After propositions by @StCyr in this PR : #72 .

He would like to add /api/<resource> in the route.
But, for developers it can be misleading. Because, in a HTTP response we can have ;

• Informations on HTTP status ;
• Which verb using ;
• Different error messages ;
• A json different according to HTTP Response ;
• And so on.

For examples :

1. This here a Jira Cloud Platform's creating issue API : https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-issues/#api-rest-api-3-issue-post-responses . We can see there is a status code to do if the resource is created or not. But also, there is the different message according to HTP response.

2. In an API, we have to send a message to developer / user to guide him. This here an example a response GitHub's API to create a project :

{
"message": "Requires authentication",
"documentation_url": "https://developer.github.com/v3/repos/#edit"
}

Here, the message indicates to developer / user has to input his credentials.

3. An API has to use the status code HTTP which is standard (200 / 201 : creating, 200 : patching, 409 : One request is in conflict with the current state of server ;

4. And so on.

I don't have skills to know everything. But I know it's very important to structure APIs if we use them.

For example of my response after creating a project space :

{
  "space": "Galadriel",
  "id_space": 213,
  "groups": {
    "GE-Galadriel": 31,
    "U-Galadriel": 31
  },
  "space_advanced_permissions": true,
  "space_assign_groups": [
    "GE-Galadriel",
    "U-Galadriel"
  ],
  "acl": {
    "state": true,
    "group_manage": "GE-Galadriel"
  },
  "statuscode": 201
}

Here I write the statuscode to root of json.
Maybe it's very interesting to write as it :

{
  "space": "Galadriel",
  "id_space": 213,
  "groups": {
    "GE-Galadriel": 31,
    "U-Galadriel": 31
  },
  "space_advanced_permissions": true,
  "space_assign_groups": [
    "GE-Galadriel",
    "U-Galadriel"
  ],
  "acl": {
    "state": true,
    "group_manage": "GE-Galadriel"
  },
  "http": {
      "statuscode": 201,
      "message" : "The space is created"
    }
}

What do you think ?

How to build our structure API ?

• Be able to define a single user as a workspace manager through a member's meatball menu
• Reverse: be able to define a manager as a simple user of a workspace through a member's meatball menu
• add or remove the member of the groups GE-myWorkspace and GE-general (see issue #64)

Related to PR #36, #70 and #71 I guess. Sort Workspace names alphabetically and not case sensitive (upper and lower case should be sorted together) for :

• (a) the left side menu
• (b) the interface listing All Workspaces
  

and show it in the space list in the navigation pane
(number of users = number of users in GE group + number of users in space user group)

Display at least one error message to users (Workspace Managers & General Managers) when an error occurs (same error message for all errors is acceptable).

When I would like to rename a space where I am not admin of this space.

I have nice the error message : You are not authorized to rename the FauxCrash space..

But it returns the status code 200 instead of a status code 401.

I use Groupfolders' API (https://github.com/nextcloud/groupfolders#api), precisely :

POST apps/groupfolders/folders/$folderId/manageACL :Grants/Removes a group or user the ability to manage a groupfolders' advanced permissions.

I use this API to enable advanced permissions and add the group which manage the groupfolder (which is the space manager).

I tried this curl :

curl -H "OCS-APIRequest: true" -X POST "https://username:pwd@instance_nextcloud/apps/groupfolders/folders/161/manageACL" -d "id=MyGoup&type=group&manageACL=true" -H "Accept:Application/json" | jq .

The answer is succeded :

{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": "OK",
      "totalitems": "",
      "itemsperpage": ""
    },
    "data": {
      "success": true
    }
  }
}

But it doesn't work :

> select * from oc_group_folders_manage where folder_id=161;
Empty set (9.125 sec)

When I create a space, vue.js doesn't redirect into this space (ref: spaceDetail).

Should return an array of objects in json format:

(addendum: we should probably replace the users array by 2 objects: adminGroup, and userGroup)

 {
     'spaceA' :   {
          users: [
                   {
                         name: 'cyrille',
                         role: 'admin',
                         email: '[email protected]',
                     },
                     {
                         name: 'dorianne',
                         role: 'user',
                         email: '[email protected]',
                      },
             ],
             quota: undefined,
      },
      'spaceB' : {
              users: [
                       {
                            name: 'cyrille',
                            role: 'admin',
                            email: '[email protected]',
                        },
                        {
                             name: 'baptiste',
                             role: 'admin',
                             email: '[email protected]',
                          },
                          {
                              name: 'dorianne',
                              role: 'user',
                              email: '[email protected]',
                           },
                    ],
                    quota: '10GB',
           },
},

Problem : A TypeError prevent code doing work when I create a project space.

Assign: @zak39 & @StCyr

The code where there is error : https://github.com/arawa/workspace/blob/348db3b97bb24519d2dc98db356ce6c3705a1b1e/src/Home.vue

Scenarios

1. I write France as value to create space project

2. Then I validate by Enter touch or click on the arrow.

3. The error is triggered

I don't know yet where is the problem. I tried to debug with debugs in methods from Home.vue component with console.debug.
But, It didn't work. I didn't see logs in the console 😕

Create a group gathering all space managers of all workspaces.
The goal will be to limit access to the application to the general manager and space manager groups (done manually by the workspace application installer and not automatically)
At each change of role of a user to become a space manager, add or remove the corresponding user from this group:

• at the time of adding a user to the workspace,
• at the time of adding a user to a subgroup,
• at the time of changing the role of a workspace member)

To complete
The idea is to:

• propose a french version of the app
• correct the english version of the app
  Thanks to the new translation files (PR incoming)

Be able to delete a member (manager or user) of a workspace through the meatball menu of each member
Remove this members of the groups: GE-myWorkspace and GE-general (see issue #64)

PR #123 fixes the "add user to group" functionality but the frontend doesn't refresh properly yet

• only GGs can execute the following actions:
• set a quota for a workspace
• rename a workspace
• delete a workspace
• create a workspace
• GE should see only their workspaces (and GG see all workspaces)

• Be able to create a subgroup to a workspace from the workspace management interface, via a "+" menu option, containing a subgroup creation icon and a highlighting of the selected option on mouseover

• Display of a free field allowing the subgroup name to be entered at the time of the mouse click (no character limit)

• Validate the creation of a sub-group via a validation arrow

• Validate the creation of a sub-group by pressing the "Enter" key on your keyboard

• Display directly the management interface of a sub-group when validating the name of the new sub-group