The munin-smart-nvme from aranemac

munin-smart-nvme's People

Contributors

Stargazers

Watchers

munin-smart-nvme's Issues

Wrong output (overflow to negative) if raw value too high (fixed)

If the raw data doesn't fit into an 32bit-integer, negative values were printed.
Fixed.

Losing passed arguments breaks support for many NVMe drives

Thank you for this very useful converter!

In using it on a number of different NVMe drives, I noticed that it breaks on any that don't work "automatically" with smartctl (e.g. the ones that need a special "-d" parameter). This is caused by the "overwrite all arguments" code, which is broken and unnecessary.

Here is a short fix that allows all arguments to be passed correctly, as configured by munin (and it also fixes the potential buffer overflow with the naked strcat):

--- smartctlcvt.cc	2024-01-07 00:22:06.099416365 +0100
+++ smartctlcvt-fixed.cc	2024-01-07 00:48:12.905155998 +0100
@@ -23,9 +23,13 @@
     char *pT;

     FILE *cmd;
-    // overwriting all arguments passed by plugin, except drive
-    char smartarg[100] = "smartctl -A ";
-    strcat( smartarg, argv[ argc-1 ] );
+    // reconstruct all arguments passed by plugin
+    const int MAXARG = 100;
+    char smartarg[MAXARG] = "smartctl";
+    for ( int i = 1; i < argc; i++ ) {
+	strncat( smartarg, " ", MAXARG - strlen(smartarg) - 1 );
+	strncat( smartarg, argv[i], MAXARG - strlen(smartarg) - strlen(argv[i]) );
+    }

     int on = 0;
     int n = 0;

This works nicely on my system with 10+ devices, some connected directly, others via USB.

Recommend Projects