Git Product home page Git Product logo

Comments (4)

Raistlfiren avatar Raistlfiren commented on May 25, 2024

@rvanlaak, I think @bpolaszek added support for your issue in PR #26. I just added support for the domain attribute in the annotations as well in my fork. I wish we could get them all merged now :)

from apybreadcrumbtrailbundle.

rvanlaak avatar rvanlaak commented on May 25, 2024

That would be great, so if #26 could be merged you would be able to make a new PR for localized breadcrumbs?

Already implemented a workaround myself now by overriding the template, and passing the translation domain per application bundle manually.

Currently we've had to move away from annotations quite often because of complex translated breadcrumbs. These could be moved back to annotations then.

from apybreadcrumbtrailbundle.

Raistlfiren avatar Raistlfiren commented on May 25, 2024

I am not really sure how to submit a PR for that, since I have already fixed depreciated TWIG methods, added a pageTitle TWIG extension, and now added this. If I submit this as a PR it will include everything changed. Hmmm....

from apybreadcrumbtrailbundle.

rvanlaak avatar rvanlaak commented on May 25, 2024

What about some cherry picking in a new branch based on your upstream/master? 👍

from apybreadcrumbtrailbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.