Git Product home page Git Product logo

Comments (9)

rvanlaak avatar rvanlaak commented on May 25, 2024

Interesting, given none of the logic around adding / parsing the breadcrumb values changes and the bundle is stable for years already. Since 1.7 it is just the "value object" that allows PHP Attributes.

Can you verify whether your Book entity has a getter on title?

from apybreadcrumbtrailbundle.

phillamarmotte avatar phillamarmotte commented on May 25, 2024

It has. In my projects it's user.username and it exists. i've got a getUsername() method.
It works with the 1.6.1.
The errors seems logical :

class User {
   public string name;
}

user = new User();

$objValue = (string) $user;

-> Fatal error: Uncaught Error: Object of class User could not be converted to string

from apybreadcrumbtrailbundle.

phillamarmotte avatar phillamarmotte commented on May 25, 2024

The Trail.php has changed.
Before you had this

if(empty($functions)) {
     $objectValue = (string) $object;
}

No cast if no functions

from apybreadcrumbtrailbundle.

phillamarmotte avatar phillamarmotte commented on May 25, 2024

The quick fix seems to replace line 103
$objectValue = (string) $object;
With
$objectValue = get_class($object);

from apybreadcrumbtrailbundle.

rvanlaak avatar rvanlaak commented on May 25, 2024

You are right, somehow introducing phpstan or csfixer did introduce this bug. I did try to prevent any refactoring (read: the Trail class is an ununderstandable mess) in order to prevent regressions. Will release a fix asap.

from apybreadcrumbtrailbundle.

rvanlaak avatar rvanlaak commented on May 25, 2024

@phillamarmotte thank you for reporting the issue, it should be fixed with the v1.7.1 release I just published.

from apybreadcrumbtrailbundle.

phillamarmotte avatar phillamarmotte commented on May 25, 2024

Thank you for your time

from apybreadcrumbtrailbundle.

rvanlaak avatar rvanlaak commented on May 25, 2024

You are welcome. Can you verify whether the patch release solves your problem?

from apybreadcrumbtrailbundle.

phillamarmotte avatar phillamarmotte commented on May 25, 2024

All my tests are green. But i found another tiny bug.
I 'm creating another issue

from apybreadcrumbtrailbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.