Breadcrumb duplicates itself during functional tests about apybreadcrumbtrailbundle HOT 26 CLOSED

Hi,
I don't know your website but do you use ajax to change your page after login ?

from apybreadcrumbtrailbundle.

No i don't use ajax, maybe i'm doing something wrong in my test but i don't know what

from apybreadcrumbtrailbundle.

Maybe the breadcrumbs are not visible but exist when you browsing pages.
How do you test it with the functional text ?

from apybreadcrumbtrailbundle.

I think I understand.

This bundle use a unique object to store the breadcrumbs declare in annotations and call this object when you want to render the breadcrumbs.

In your functionnal tests, you browse virtualy another page in the same function but the breadcrumbs object is still set because you don't have really change the page.

from apybreadcrumbtrailbundle.

Auto closed, sorry.

I've update a bit the bundle. It resets the trail after each request.
Can you update and test ?

from apybreadcrumbtrailbundle.

Okay I update and test .. suspense !

from apybreadcrumbtrailbundle.

Somehting wrong ?

from apybreadcrumbtrailbundle.

It seems that i don't have breadcrumb when i'm logged in, try to check what happens

from apybreadcrumbtrailbundle.

I'll try another correction.

from apybreadcrumbtrailbundle.

Try this new version please.

from apybreadcrumbtrailbundle.

Now if i display an other page during the test, it keeps the breadcrumb from the first page, and adds parts which are added with the "add" method form the current page.

from apybreadcrumbtrailbundle.

Ok, I can't do more right now. I take a look this week end.
Sorry.

If you understand why this behavior occurs, contact me here.

from apybreadcrumbtrailbundle.

Okay thanks ! If i have time i will take a look and try some things.

from apybreadcrumbtrailbundle.

I found a solution !

With the first fix you suggested with "reset" function, it missing just a test : if the request is master or not.

It didn't work because I have a component in page header, and the master request breadcrumb was overridden by the component breadcrumb.

So with the test in "onKernelController" event, it works fine :

if($event->getRequestType() == HttpKernelInterface::MASTER_REQUEST) {
            $this->breadcrumbTrail->reset();

            $this->addBreadcrumbsFromAnnotations($this->reader->getClassAnnotations($class));

            // Annotations from method
            $method = $class->getMethod($controller[1]);
            $this->addBreadcrumbsFromAnnotations($this->reader->getMethodAnnotations($method));
        }

from apybreadcrumbtrailbundle.

But with this statement, do we have to call reset() ?

from apybreadcrumbtrailbundle.

Yes, or else we still have the original problem on functional tests.

from apybreadcrumbtrailbundle.

And with the new fix 1.

if (!$this->breadcrumbTrail->count()) {

}

Does it work too ?

from apybreadcrumbtrailbundle.

I haven't try and I don't think it works, do you want me to try ?

from apybreadcrumbtrailbundle.

Yes please if you have time to waste :D

from apybreadcrumbtrailbundle.

I don't think i'll have time tonight, but surely tomorrow :) ! To be sure, it's with new fix 1 and my test i have to try, and no reset function ?

from apybreadcrumbtrailbundle.

yes.

from apybreadcrumbtrailbundle.

After testing, it doesn't work with the new fix 1

from apybreadcrumbtrailbundle.

Voilà corrigé.

from apybreadcrumbtrailbundle.

It works fine, merci :)

from apybreadcrumbtrailbundle.

Great, first fix on this bundle. Thanks for your help.

from apybreadcrumbtrailbundle.

You're welcome !

from apybreadcrumbtrailbundle.