Git Product home page Git Product logo

palettes-for-tumblr's Introduction

About me

I am a WebExtension developer and Tumblr theme author.

For what I'm currently working on, check out my pinned repositories!

I hold the following certifications:


Guidelines for interaction

As a contributor, you can make my life as a maintainer easier by:

  • Accepting my code suggestions through GitHub's interface
  • Marking conversations as resolved as you address them
  • (Re-)requesting my review when you're ready for one

palettes-for-tumblr's People

Contributors

aprilsylph avatar dependabot[bot] avatar marcustyphoon avatar renovate[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

palettes-for-tumblr's Issues

Text under dropdowns in the new layout doesn't display correctly

Platform

Windows 10, version 21H2

Browser

Chrome v115.0.5790.102

Addon version

v1.0.2

Details

I switched to Palettes for Tumblr to change the font size and family to the one Tumblr used previously (Helvetica Neue, and a base font size of 14px) for accessibility issues since the current default font is hard to read for me as someone who wears glasses and makes my head hurt.

With the new layout, I find the some of the text under the Account and Settings dropdowns doesn't display properly and it looks weird compared to the rest of the text in the dash, as you can see in the screenshots I attached to this issue. However, this doesn't seem to affect to each blog menu, just like you can see in the third screenshot:

Captura de pantalla 2023-07-21 111918

Captura de pantalla 2023-07-21 111944

Captura de pantalla 2023-07-21 113349

I tested it with the default and the rest of the fonts available and it just happens with that one, which means it's a font issue. I also tested it with an old userscripts I used to fix this and it's still happening. Is there a reason why this is happening? Is there a way for fix that without having to change the font settings I'm using?

Gifts page color issue (Tumblr bug)

Platform

MacOS 10.15.7 x86

Browser

Ungoogled Chromium v108.0.5359.94

Addon version

1.0.1

Details

For some reason, the gifts page uses the black and white css variables instead of the white-on-dark css variable, depending on whether or not you have the true blue palette selected.

Should I support request this? The functional issue only occurs when using this extension, but the erroneous code is clearly in redpop and working around it here would be fairly silly; I'm never sure where to report things like this.

Screenshot with "dark mode" selected on Tumblr and "true blue" selected in this extension:

Color theme problem

Platform

Mac 13.0

Browser

Chrome 125.0.6422.113 (64 bit)

Addon version

Palettes for Tumblr 1.0.2

Details

The bits that are blue are supposed to be pink, such as the upper pencil icon, the line under following, "explore all of tumblr", etc. They were pink until today and I don't know why they're suddenly blue. Everything else is working fine.

Screenshot 2024-05-23 at 6 40 16 PM

Disable/intercept Alt+P "change palette" shortcut

Pressing alt-p with a custom palette selected currently does "nothing," but actually changes the Tumblr-selected palette that is being overridden.

On the one hand, for developers this is excellent for testing what hilarious things happen when you apply a regular palette over vampire or pumpkin; on the other hand, this could be improved to either do nothing or to navigate through the extension's palette choices for regular users.

Re-importing a file has no effect

Platform

MacOS 10.14.6

Browser

Edge 98.0.1108.56

Addon version

v0.3.0

Details

Attempting to trigger the file input twice in a row with the same file results in no UI feedback, as there is no change to the hidden input element and so loadFromFile is not run.

Naturally, only people editing the JSON file are likely to run into this.

Some accent colors may not be overridden

Platform

MacOS 14.4.1 arm64

Browser

Chrome 125.0.6422.77

Addon version

v1.1.0

Details

While the issue wherein every accent color did not apply was fixed in #185, we will gradually see UI elements go back to not being correctly colored if/as Tumblr transitions to the new --accent, --accent-hover, --accent-pressed, etc variables.

Not sure what the plan is to integrate with this (generate them with an algorithm? would be neat), but I'll file the issue so we have it documented.

The first one I have encountered is the unread count number in the sidebar.

When using a different font, display [tumblr] as it appears without a font change

I have no idea if there's any way of fixing this, since I can't figure out how it works in the first place, but when using the default Favorit font, [tumblr] (with the brackets) appears as a wordmark using the tumblr logo font. (In both posts and tags.) If there were any way of keeping this option when Palettes is used to change fonts, that would be awesome.
image

Visual inconsistency on /blog/view with blog colors disabled

Platform

MacOS 10.14.6 x86

Browser

Edge 104.0.1293.54

Addon version

1.0.1

Details

Turning Tumblr's "use blog colors when viewing blogs" setting off sets palette-specific color variables on the blog view modal's scrollContainer element that are a mix of hardcoded values and references to the palette variables that this script affects.

With a Tumblr palette and extension palette that clash, this can lead to scenarios. (Some of them are hard to read; others just look funny.)

Not sure if this is really fixable without a significant amount of feature creep.

ALT Image Descriptions Bubble is Default Color

Platform

Windows 10 Home version 21H1

Browser

Firefox 101.0.1 (64-bit)

Addon version

v1.0.1

Details

When Tumblr added the ability to view ALT image descriptions by pressing a button, I noticed that the shade of purple for the text bubble is not overridden by this extension.

I use three UserStyles (via Stylus) for Tumblr on top of the Palettes extension -- two are my own which just adjust the width of the in-dashboard blog viewer and tint the hyperlinks in post bodies, and the other is Custom Dashboard Palette by paw. I have the same exact hex codes across both the latter UserStyle and the Palettes extension, so I can only assume that the background-color property does not use the same purple variable.

Due to the nature of the text bubble vanishing if one clicks anywhere outside of it, I am unable to Inspect it via my browser to find what is responsible for the color difference.

Screenshot 2022-06-28 112728

[Feature Request] Arbitrary values for FontFamily

It could be useful to allow users to manually set whatever font they want from their system (probably via a text input field to avoid the adding complexity by making the extension scan their system for fonts?)

Would help users who use fonts such as OpenDyslexic for accessibility reasons or weirdos like me who like browsing tumblr with a monospace font :P

Tumblr

Platform

Windows 10

Browser

Microsoft edge

Addon version

Unsure, it is the app from app store, the latest.

Details

I am unable to save a header image or avatar image successfully always reverts to default image.
The images are within the size specified,

"Change palette" button is not hidden

The label has changed from "Change Palette" to "Change palette" for consistent casing. The extension's logic for hiding the button thus needs to be updated too.

Custom primary accent color no longer overruling tumblr system accent

Platform

Windows 10 Pro

Browser

Firefox 126.0

Addon version

v1.0.2

Details

Starting a couple of days ago, the color I picked for the primary accent in my custom theme stopped showing up, and the primary accent instead used the color associated with the theme I had picked through the tumblr settings. I tested changing through all the themes made available through palletes for tumblr, and they all kept the same primary accent that was determined by tumblr itself. When I change my theme through the tumblr settings, the only thing it affects is the primary accent; all other colors remain consistent with whichever theme I selected through palletes for tumblr.

Dark Mode with old Tumblr palettes (e.g. circa 2013/2016 modes)

Previously, Dark Reader used to work symbiotically with these two palettes. Recently, though, it is now being overwritten by this extension. It would be nice for this extension to have an option for these two specific themes if its feasible (it would essentially be the Dark Mode palette but with the old blue background color options).

Font size inconsistency between left and right sidebars?

As seen below, the font size for the left and right sidebar are different, with the text in the leftside navigation being noticeably smaller. When I deactivated Palettes, both sidebars had the same font size. When I change the font size in Palettes, it does affect both sidebars, but the left side remains consistently smaller.
You can observe the difference in the screenshot below. (My chosen font size here is 16, if it matters)
font-size

(Ive not used github in quite a while, please let me know if I put this in the wrong place or anything)

The word "Notes" does not show

Platform

Windows 10

Browser

Firefox 107.0 (64-bit)

Addon version

v1.0.1

Details

image
The word "Notes" does not show when using this extension.

As of right now, neither "Palettes-For-Tumblr" nor "Old Blue" on Xkit works

Bug description

When any palette other than "default" is selected, the entire page BG becomes totally white. Tumblr is still essentially functional like this, it's just that the primary thing this addon is meant to do, does not.

I also attempted reinstalling "Old Blue" on my Xkit and it does the exact same thing, for in case knowing that is of any use to you. Also the Xkit button is now black instead of grey on the Default look and light grey instead of dark grey on the white, again, just for if that information is helpful.

Platform information

I'm using the latest version of Firefox (85.0.2) and the latest version of Palettes for tumblr (0.1.3) and the latest Xkit (7.9.2), at least as far as I am aware.

Screenshots

image
image
image

<small> text size unaffected by "Base Font Size" feature

Platform

Windows 11

Browser

Firefox 127.0.2 (64-bit)

Addon version

1.1.0

Details

Tumblr post text that's styled with <small> tags stays at 13px, does not increase/decrease in size to follow the base font size set by this extension's "Change Base Font Size" feature.

Palettes returned to default, won't save new settings

Platform

Windows 11

Browser

Firefox 127.0 (64-bit)

Addon version

1.1.0

Details

The extension has returned to default or stopped working for me, all Tumblr pages are now back to default color and font size settings.
01
[A page that was left open from a week ago, showing previous palette settings]
02
[The same page opened today.]

When opening the extension, Default is the only option for changing palette.
03
The other palette options are available within Manage Palettes as templates, but new palettes created in the the Manage Palettes menu can't be saved (pressing Save button does nothing).

Font face and size changes do not save either.

I have tried disabling and re-enabling the add-on, but it made no difference.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

  • chore(deps): update actions/setup-node action to v3.6.0
  • chore(deps): update dev dependencies (eslint, eslint-plugin-import, eslint-plugin-n, web-ext)

Detected dependencies

github-actions
.github/workflows/build.yml
  • actions/checkout v3
  • actions/setup-node v3.5.1
  • actions/upload-artifact v3
.github/workflows/ci.yml
  • actions/checkout v3
  • actions/setup-node v3.5.1
.github/workflows/publish.yml
  • actions/checkout v3
  • actions/setup-node v3.5.1
  • actions/checkout v3
  • actions/setup-node v3.5.1
.github/workflows/release-notes.yml
  • actions/checkout v3
  • actions/upload-artifact v3
npm
package.json
  • normalize.css ^8.0.1
  • webextension-polyfill ^0.10.0
  • chrome-webstore-upload-cli ^2.1.0
  • eslint ^8.31.0
  • eslint-config-semistandard ^17.0.0
  • eslint-config-standard ^17.0.0
  • eslint-plugin-import ^2.26.0
  • eslint-plugin-n ^15.6.0
  • eslint-plugin-promise ^6.1.1
  • web-ext ^7.4.0

  • Check this box to trigger a request for Renovate to run again on this repository

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.