april / decklist Goto Github PK
View Code? Open in Web Editor NEWThe code behind decklist.org, which generates DCI Registration Sheets.
Home Page: https://decklist.org/
License: MIT License
The code behind decklist.org, which generates DCI Registration Sheets.
Home Page: https://decklist.org/
License: MIT License
Would it make sense to cut down the maximum entries in the sideboard to 15 different card names?
As that is the maximum lines available and all further entries mess the judge box up, basically rendering all list unusable or unreadable:
I think cutting down to 15 entries (no matter how much cards there are in total) keeps readability at least.
Same could apply to the decklist and the number of available lines for card entries, too.
There should be an appropriate (and additional) warning for sure if not all cards make it to the list!
For Standard, Modern, or Legacy, verify cards against the ban list.
For whatever reason, I cannot get it to accept the card Kingpin's Pet, despite it being in the json file. other cards with apostrophes work fine.
Many cards from the following sets are not recognized by the decklist system:
Just for example, Bomat Courier from the basic Pioneer burn challenger premade deck, is not recognized by the decklist system.
The same missing sets/cards are fully recognized by the Gatherer, Magic Online, TappedOut, MTG Print, and Cockatrice.
I appreciate that this project is a labor of love. If someone can help to validate the card database for completeness, that would be super.
If the user enters an unrecognized card name, any apostrophes will be rendered as their HTML code of "'". (The "single right quote" character that some sites use is rendered properly.)
Wouldn't it be great if players could simply select WotC or SCG style decklists? One checkmark is all that would be needed to switch back and forth between them. Heck, we could even include the SCG waiver, if we were being ambitious.
The file used here
decklist/js/cards/generatecards.sh
Line 8 in 4b5919b
doesn't exist any more. All data is now contained in AllCards.json
.
Additionally, there have been some breaking changes and enhancements: https://mtgjson.com/changelog.html
Also, there is now a .xz
file available which is 50% smaller in size than zip!
As the title says, it is very common to use the line breaks for visually separating card blocks. The rest of the sort orders do it this way. But the "original" sort order, ignores any line breaks in the text area and clumps all cards together.
Under 'Deck Sort Order,' when choosing to sort by type, cards are sorted as follows:
Lands,
Creatures,
Instants / Sorceries (mixed),
Artifacts / Enchantments / Planeswalkers (mixed)
I can see the logic of combining Instants and Sorceries, and even Artifacts and Enchantments to a lesser degree, though I'm not sure if mixing types at all is intended behavior or not. Planeswalkers may make more sense being grouped alone (or with creatures, if types are intended to be mixed).
Cyrillic text is messed up in the output.
Would make it a lot easier to support mobile browsers, and jQuery UI is kind of awful anyways.
Hey, basically the title, the site cannot be visited properly via HTTPS right now.
Hi April and crew, is it possible to add support for Lorcana? They have an official decklist sheet here: https://cdn.ravensburger.com/lorcana/op-constructed-decklist-registration-sheet
Thanks,
Jared
(@JaredLTomlinson)
I always use the "color" settings for sorting and it seems to be recently broken. I filed out my fairly stock Modern Dredge list and it sorts Prized Amalgam first by itself, then every other spell in a section, then the lands in a section. Maybe it thinks all the monocoloured cards are colourless for some reason? Happy to give more specific information if needed.
Add tooltips, particularly to the main deck and sideboard sections.
"Lim-Dûl's Vault" appears as "Lim-Dßl’s Vault" in the output.
Decklist I was using for reference: http://deckstats.net/deck-6769717-c29d2b7f200b0fd2813a6dbf1e7a2291.html
Currently, README is pretty sparse, not explaining how cards are generated, under-the-covers details of how the site works, or how to use it (like directlinking.html does). At the least, it seems that directlinking could be moved entirely into README as a section, and the link could point to it rather than being a separate page.
Older (smaller) DCI numbers will need to be converted into the new format. Currently don't know the formula to do this, though.
If someone enters:
Tarmogoyf
The system should probably interpret it as:
1 Tarmogoyf
WPN released a "new sheet" that changes the DCI logo to the MTG Planeswalker log
mtg_constructed_deck_registration_sheet_.pdf
o
Most projects will include a CONTRIBUTING.md
file (like the README) in the root directory of the project to help define certain style guidelines and principles that a project adheres to. This is an exmaple, which is used by the Cockatrice project. I noticed that the most recent commit made some changes to the code to start making a consistent style (tabs->spaces, apostrophe-surrounded strings, etc.), so I figured that now may be a good time to establish your preferred style so others can use it as well.
Some websites and applications use the "single right quote" character ("’", U+2019) rather than the normal apostrophe. The decklist generator does not know to convert this to a regular apostrophe and will not recognize the card name.
Unicode sucks in PDF... can we make it work?
Due to the 'ae' checking code.
Now, with more than one layout template (#42), there should be option to preset that in the url, too!
Needs documentation here: https://github.com/april/decklist#direct-linking
Need to validate the following:
decklist does not seem to recognize Attraction and Sticker cards, and therefore cannot add them to a competitive event deck registration sheet in a separate section from Main Deck/Sideboard. They are just added to the Main Deck.
Attractions: https://scryfall.com/search?as=grid&order=name&q=type%3Aattraction
Stickers: https://scryfall.com/sets/sunf?as=grid&order=set
Let people know if their deck is properly configured.
I've run into the issue when copy/pasting from other sources (especially PDF) that trailing spaces cause card names to not be recognized – it'd be great if they could be ignored.
Add a table number field
I uploaded a decklist with 3 Uro, Titan of Nature's Wrath
, which isn't recognized quite yet, but on the decklist it shows up as 3 Uro, Titan of Nature's Wrath
. Same happens with 2 Rakdos's Return
-> 2 Rakdos's Return
, but 2 Rakdos' Return
-> 2 Rakdos' Return
.
When I put in my Jund Sacrifice decklist and hit sort by CMC I get all of the cards sorted in alphabetical order instead. I've seen this issue before with my Dredge decklist too.
Screenshot included for clarity:
If it helps, this is the maindeck and sideboard I used:
3 Beanstalk Giant
4 Blood Crypt
1 Castle Locthwain
4 Casualties of War
4 Cauldron Familiar
4 Fabled Passage
5 Forest
4 Gilded Goose
3 Korvold, Fae-Cursed King
1 Massacre Girl
4 Mayhem Devil
1 Mountain
3 Murderous Rider
4 Overgrown Tomb
4 Stomping Ground
2 Swamp
1 Thrashing Brontodon
4 Trail of Crumbs
4 Witch's Oven
2 Duress
3 Lovestruck Beast
1 Massacre Girl
4 Noxious Grasp
2 Shifting Ceratops
1 Thrashing Brontodon
2 Wicked Wolf
If you have a mainboard of 4 Mountain
and a sideboard of 4 Mountain
, it will create a decklist with 8 Mountains in the main and 4 in the sideboard.
I think this is related to @Nightfirecat's recent changes.
For instance, a decklist with 1 Ionize, 1 Seal Away, and 1 Expansion // Explosion will be grouped correctly when just Expansion is written:
1 Expansion
1 Ionize
1 Seal Away
However, when the card name is written out as Expansion // Explosion, it goes into its own category:
1 Ionize
1 Seal Away
1 Expansion // Explosion
I find it a bit odd to see the PDF display update when I tab between fields or use the arrow keys / Home + Down keys to navigate within one of the textareas. Is there any reason we need to update it whenever keys are pressed?
Card list have changed since last update in Feburary
A vast majority of handwritten lists will have lands separate from non-lands. It'd be nice if this could also do that while still allowing all of the different sort mechanisms.
I want to write my id of Magic Online as deckdesigner name.
Though my id starts with lower-case letter, this script capitalizes it.
Could you make the script not to capitalize the deckdesigner name?
Changes to MTG sanctioning and organised play phase out the DCI Logo used on deck sheets. DCI numbers are also no longer in use.
The latest logo appears to be the one used on this document.
The Warhammer 40k cards aren't recognized and are put in a separate section rather than being grouped with the appropriate type.
I verified that this issue is fixed by #76 (I see the 40k cards in decklist-cards-min.js
).
The card Who/What/When/Where/Why
isn't correctly recognized, even though its name is correct.
Update: #33 (comment)With the UNS Oracle Update, it is now officially
Who // What // Where // When // Why
It's an error in your database creation. Because you handle that card the same as any other split card and therefore it ends up in your database with double //
separation with spaces "Side1 // Side2"
:
"who // what // when // where // why":{c:"S",b:"sml",m:98,n:"Who // What // When // Where // Why"}
But it should be single /
separation without spaces "Side1/Side2"
for that particular card:
"who/what/when/where/why":{c:"S",b:"sml",m:98,n:"Who/What/When/Where/Why"}
That's actually the same issue with the Cockatrice app, because mtgjson (used as source for the card database) has no split cards but all single halves. In order to create a database one has to combine them to a single card with its combined names.
Problem is the unique and different naming scheme for the UNH split card in comparison to aftermath or fuse cards for example.
When posting a list by URL with name and dci attributes the fields are set to disabled. Can this be removed? While we like to autofill in usernames from our site we still want them to change the values easily if they need to. example link:
https://www.decklist.org/?firstname=andre&lastname=liverod&dcinumber=12345
Right now we just post blank so the users set this themselves on your site.
Survival of the Fittest should always show as Survival of the Fittest, no matter if you use:
1 survival of the fittest
1 Survival of the Fittest
1 Survival of THE Fittest
etc.
Given past issues with cards with special characters—and the edge cases therein—and the implementation of error handling, we may benefit from starting to write a set of test cases to ensure we don't introduce regressions or partial fixes to these issues. (ref: #19, #24)
Since we can identify cards by their card name, we could confirm their inclusion in the computed deck list after parsing some given text. This would be a more secure and automated method of testing problem cases, rather than confirming by-eye.
IMO, this is a low-priority effort, but would be worth putting effort toward at some point in the future.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.