Git Product home page Git Product logo

Comments (6)

stnguyen90 avatar stnguyen90 commented on June 18, 2024 1

@ItzNotABug, haha no worries! I want to minimize changes to your existing PR so that, hopefully, it can get merged sooner. What you can do is create a new PR with your previous branch (ItzNotABug:refactor-933-use-local-timings-for-premium-support) as the base.

from console.

ItzNotABug avatar ItzNotABug commented on June 18, 2024

Hey @stnguyen90, ig I completely missed this required change in the existing PR. The support executive illustration seems to be no longer required

Do you want me to create a separate PR or refactor the existing one? Again, my bad I missed this 😅

from console.

ItzNotABug avatar ItzNotABug commented on June 18, 2024

@stnguyen90 what should be the case if the account isn't a paid account?
I was thinking of using a common message for both the types like below but the CTA would differ -

support support.premium

from console.

stnguyen90 avatar stnguyen90 commented on June 18, 2024

what should be the case if the account isn't a paid account?

Does it need to change? The current behavior hides the "Get personalized support ..." text if a user is on the Starter plan, right?

from console.

ItzNotABug avatar ItzNotABug commented on June 18, 2024

@stnguyen90 Yupp, but it would look like -

Premium Support
[Get Premium Support]

Doesn't seem that nice, looks a tad repetitive. Also adding the default timings would let the user know about the working hours.

from console.

stnguyen90 avatar stnguyen90 commented on June 18, 2024

@ItzNotABug, it might be good to create the PR and share the screenshot of what it'll look like. Then, I can show it to design to sign off on it.

from console.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.