appinesshq / ae-nft Goto Github PK

Can these be put in a meta_info field to try sticking to a more compatible NFT <> FT standard?

ref: https://github.com/mradkov/aeternity-fungible-token#meta_info

Is this return of bool values actually needed? Can you use unit where there is no intention to return any value?

I think it would be great to have a corresponding AEX proposal for this NFT "reference implementation":

• https://github.com/aeternity/AEXs

Is get_uri misspelled in nft.aes?

In line 77, should get_uri be get_url ? (i->l or I->L)

I guess you would want this entrypoint to throw and error and fail if the recipient / receiver doesn't implement this interface or returns false.

see:

• ae-nft/contracts/NFT.aes

  Line 165 in 05e4ef9

  None => false

• ae-nft/contracts/NFT.aes

  Line 168 in 05e4ef9

  false

Can you define an interface file with the interface of the standard and separate this contract as a reference implementation?

if you continue working on this I highly recommend to use the upcoming aeproject version. it's currently in beta and will soon be released.

• npm i @aeternity/[email protected]

migration guide:

• https://aeternity.com/aeproject/main/migration-from-3.x.x-to-4.x.x/#migration-of-old-projects

it's still beta and for consistency reasons we will probably introduce additional changes in regards to function and variable name around the sdk, see aeternity/aeproject#402

everything related to client will probably be renamed to aeSdk

you get a lot of benefits using the latest aeproject version as it is using devmode of the aeternity node

I know this is early reference implementation (#7 ), but .. Can you maybe provide more explanatory error messages and maybe if possible for all of them to follow a certain format? (it will be easier to handle things off-chain programmatically if so).