app-vise / kvk-api Goto Github PK

Looks like this code is directly copied or strongly inspired from Werkspot/kvk-api of which i'm the original author.

It would have been nice to have this mentioned somewhere like it is stated in the original MIT licence.
Although i'm no longer working for Werkspot it would be nice to be credited for my hard work and inspiration

It could also be that it is just a coincidence since writing an good structured API client can only be done in a couple of ways 😉

The KVK has stated on the website that the Search V1 API will stop working and all users should migrate to Search V2. This library should move over to V2, as it will stop functioning once the KVK turns off V1.

Hallo,

Ik probeer het adres gesplitst in straat, nummer, postcode, plaats etc op te halen van het hoofdadres. Dit lijkt echter niet mogelijk. Is dit simpelweg nog niet geimplementeerd in de package of zie ik iets over het hoofd? Als dit wel mogelijk is, hoe zou dit dan moeten?

Ik gebruik op dit moment de endpoint getBasisProfielHoofdVestiging maar hier kom ik niet echt verder mee.

Gr. Lauren

Fatal error: Uncaught Error: Using $this when not in object context

php 8.1

try {
$resultaten = $this->client->search($query);
foreach ($resultaten->getResultaten() as $searchResult) {
// do something with $searchResult
}
} catch(NotFoundException | ApiException $exception) {
// handle error
}

Hi there! First of all thank you for making this package. We were using the older werkspot package until recently, and this seems like a suitable replacement. In the previous version, we could extract a number of attributes / fields from results that seem to be missing from this new package, namely: the postal code, and street number. It seems relatively easy to add these to the results, but I thought there may be a specific reason why your package does not include them.

I would be willing to make a PR to add the extra fields soon-ish, if you are interested in that.

On a tangent -- maybe this should be a different issue on its own: will you be adding official releases with versioning at any point? It seems more robust to use your package that way, as any changes in the consumer-facing API will break existing projects. A small example is the getKvkNumber() which is different from the name as returned by the KVK API: kvkNummer. Changing this method name for more consistent naming would break existing code that uses the old method, if the package has no semver versioning.

Edit: Looks like I was looking at the wrong resources for the new KvK API, and it's no longer possible to get the postal code and street number without calling additional API endpoints. Sorry for any confusion caused!

Is there any roadmap available? Will there be a stable version released any time soon?

I noticed that there is a mix of English/Dutch language used in the code? Will this be converted to all English eventually?

Please make the certificate argument optional, as the KVK has move to a different certificate that is universally accepted. That means it is no longer needed to specify a root certificate, as it is already trusted by the system certificate store.