api3dao / ois Goto Github PK

operation and fixedOperationParameters needs to be optional to implement this Airnode feature. #43

Necessary for api3dao/airnode#1544. The major version bump results from adherence to semver with respect to the breaking change in #66

Currently OIS validation allows an empty reservedParameters endpoints array. I confirmed, based on a reported issue on discord, that gateway requests to an Airnode deployed with such an empty array causes a difficult to debug error: {"error":"Error: Cannot read property 'length' of undefined"}.

See this and subsequent comments for a discussion on needing _type and not merely checking for a non-empty array.

OIS component of api3dao/airnode#1492

Blocked by api3dao/airnode#1209

Necessary to implement _minConfirmations and _gasPrice on the Airnode side in api3dao/airnode#1393 and api3dao/airnode#1492, respectively.

OIS component of api3dao/airnode#1393

See: api3dao/airnode#1422 (comment)

The README seems a bit underwhelming and could be improved at least by adding installation instructions.

OIS provides the environments for pre/post-processing here:

Therefore, for api3dao/airnode#1544, 14 needs to be removed.

Port api3dao/airnode#1286 to https://github.com/api3dao/ois

To verify, the value below can be changed to a non-number and the tests still pass

Validating this is slightly complicated by multiple reserved parameters e.g. _times: ',10000,', but it still should be attainable after splitting using transform and something like:

export const stringifiedNumberSchema = z.string().transform((val) => parseFloat(val));

Currently, within oisSchema, the oisFormat version must match the package version exactly, down to the patch, because of:

This forces SemVer-incompatible coupling of released packages. For example, Airnode v0.8.0 was released with @api3/[email protected] as a dependency and therefore users of Airnode v0.8.0 cannot use an oisFormat version other than 1.1.1.

The oisFormat version is incorrect in the repo README.md file for the following two tags.

https://github.com/api3dao/ois/tree/v1.0.0 and https://github.com/api3dao/ois/tree/v1.1.1

Release OIS v1.2 to signal a breaking change.