aphistic / gomol-json Goto Github PK

Allow users to choose whether they want to start when a connection can't be made or not.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x58 pc=0x6fe6f3]

goroutine 6 [running]:
git.corvisa.com/plat/domo/vendor/github.com/aphistic/gomol-json.(*JSONLogger).write(0xc420202090, 0xc420314480, 0x346, 0x47e, 0x0, 0x0)
/go/src/git.corvisa.com/plat/domo/vendor/github.com/aphistic/gomol-json/json_logger.go:316 +0x43
git.corvisa.com/plat/domo/vendor/github.com/aphistic/gomol-json.(*JSONLogger).trySendFailures(0xc420202090, 0xc42001e180)
/go/src/git.corvisa.com/plat/domo/vendor/github.com/aphistic/gomol-json/json_logger.go:355 +0xa9
created by git.corvisa.com/plat/domo/vendor/github.com/aphistic/gomol-json.(*JSONLogger).performReconnect
/go/src/git.corvisa.com/plat/domo/vendor/github.com/aphistic/gomol-json/json_logger.go:336 +0xa5

Attributes added to the top level gomol structures aren't included when sending messages with the JSON logger.

The code to handle failed messages currently uses a slice of a slice of bytes to handle re-sending messages. When a message is successfully sent, the slice that was sent may not be GC'ed correctly if the array underlying the slice is still holding a reference to the bytes that were sent. The library just needs to be tested in a few error modes when sending a large amount of messages to make sure everything is being cleaned up correctly.

When running the init it can take a long time to finish if the socket connection is dropping packets instead of rejecting them, causing startup to be delayed for way too long. It should be lowered to 60 seconds by default but allow configuration for a higher or lower value.