apeworx / py-tokenlists Goto Github PK

Two test cases currently are failing that were added to Uniswap's repo:
https://github.com/Uniswap/token-lists/blob/main/test/schema/example-crosschain.tokenlist.json
https://github.com/Uniswap/token-lists/blob/main/test/schema/extensions-valid-object.tokenlist.json

Overview

I have a repo that makes it easy to build a tokenlist out of on-chain data. The output file is saved to disk.

Specification

Installation currently goes through requests.get

If we see it starts with "file://" we can load the file instead of using requests.

Dependencies

I don't think there are any.

Environment information

python
ape

What went wrong?

when getting a ValueError for tokenlist, not found, the repr of the list is really long.

it looks like from this line: https://github.com/ApeWorX/py-tokenlists/blob/main/tokenlists/manager.py#L129-L131

For some reason, it seems like tokenlist.name is a massive data object repr for some reason, but I am not sure, will have to investigate.

more info:
ApeWorX/ape-tokens#18

How can it be fixed?

Fill this in if you have ideas on how the bug could be fixed.

Overview

Would be nice if there was a way to upgrade a tokenlist

Specification

Probably need to add the original download URI to Tokenlist, so that it can be referenced for later (or in a separate section)

Then add tokenlists upgrade that will go through all the lists and update them to the latest

Dependencies

n/a

Environment information

• Python Version: 3.9.7
• OS: macOS

Latest.

As per this PR: Uniswap/token-lists@74d8910,
object schemas are now supported in the schema for extensions.

However, when trying to use them, the package fails with a pydantic validation error: Incorrect extension field value: {...}

You will notice the tests fail for this reason too.

How can it be fixed?

Probably the best way is to build another model for the new extension schema and include the model in the Union of supported types.

Some people might want to use this as a command line application, so let them!

Overview

It'd be really nice to be able to have an index of installable lists from the index provided at https://tokenlists.org/.

This would also support installing via alias from that index, as well as the normal URI method

Specification

$ tokenlists list --all
Installed lists:
...

Available lists:
...

Dependencies

n/a

Overview

I installed a list with invalid syntax. It installed without error, but the next time the process started, creating the manager erred with pydantic.error_wrappers.ValidationError: 63 validation errors for TokenList and a long list of the errors. It does not say what file it was processing.

Specification

If a file fails to load, instead of raising a ValidationError, a warning should be emitted with the name of the file.

The default choice could be stored in the data folder, making it possible for there to be an automatically detected default when loading the library

Environment information

• Python Version: 3.9
• OS: macos

Python environment

$ pip freeze
# ...copy and paste result of above command here...

What went wrong?

Please include information like:

Tried to load this token lists: https://github.com/Uniswap/token-lists/blob/main/test/schema/example-crosschain.tokenlist.json
but it fails with ValidationError about extensions since it is dict and not one of the expected types

How can it be fixed?

Handle multi-chain bridge like extensions data structure (dictionary of sorts)

https://github.com/rossmacarthur/serde

See ApeWorX/ape#117

Add support for the cross-chain extension described here:
https://github.com/Uniswap/token-list-bridge-utils

https://github.com/biqqles/dataclassy

Environment information

• Python Version: 3.8
• OS: linux

What went wrong?

ERROR: tokenlists 0.1.1 has requirement pyyaml<6,>=5.4.1, but you'll have pyyaml 6.0 which is incompatible

How can it be fixed?

Fill this in if you have ideas on how the bug could be fixed.

Thanks for your work, but sry, I want to know how to use it?

I was trying to load "dai" but I had to instead load "DAI". Should these checks be case-sensitive? It might make duplicates more common, but I doubt it.