apache / incubator-kie-tools Goto Github PK

Hi, could you add support for actually writing condition expressions?

The UI is already almost there:

I would like to be able to express the following:

<bpmn2:sequenceFlow id="SequenceFlow_1" name="eventName" sourceRef="Task_1" targetRef="ExclusiveGateway_2">
      <bpmn2:conditionExpression xsi:type="bpmn2:tFormalExpression" id="FormalExpression_1" language="http://www.example.com/language">some-expression</bpmn2:conditionExpression>
</bpmn2:sequenceFlow>

I can help, if provided some guidance :)

(this is a copy of kiegroup/kie-tooling-store#39, which was the wrong repo, I guess?)

The modeler for processes generates a parallel gateway by default. The most common gateway tends to be Exclusive. It would be great if the default was exclusive as "99% of the time" we are having to change from Parallel back to exclusive.

Hi everyone,

I tried to integrate the standalone DME editor into a site with a strict CSP and as you may expect it only thrown a bunch of errors in the js console. After looking at the code I saw that there is an iframe loaded with a few inline scripts and a ton of other scripts.

Content-Security-Policy: default-src 'none';base-uri 'none';manifest-src 'self';script-src 'nonce-foobar=' blob:;style-src 'self' 'unsafe-inline';img-src 'self' data: blob:;font-src 'self' data:;connect-src 'self';media-src 'self';frame-src 'self';frame-ancestors 'self';worker-src 'self';form-action 'self'

Is there any way to get this working without creating my own bundled standalone editor? Why is the iframe needed at all?

Sorry, I never used kogito tooling before, so my questions quite be a bit clumsy.

Best regards,
Klaus

Hi,

Please see https://github.com/kiegroup/kogito-apps/pull/654

I am unable to embed the DmnEditor following the instructions I can find.

Can you please assist.

Test case:

1. Create a decision in Online Editor with type = literal expression and code: context merge([{a: 1}, {b: 2}])

Expected Result:

1. No validation errors

Actual Result:

1. Validation error: ERR_COMPILING_FEEL: Error compiling FEEL expression 'context merge([{a: 1}, {b: 2}])' for name 'FEEL func' on node 'FEEL func': syntax error near 'merge'

Root cause:
Looks like Kie Extended Services module ships with DMN Runner that depends on kie-dmn-core version 7.59.0.Final, this version does not support new FEEL functions.

Is it possible to bump the kie-dmn-core version to 7.62.0.Final at least? We would like to use the functions defined in https://github.com/kiegroup/drools/blob/7.62.0.Final/kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/extended/KieExtendedDMNFunctions.java.

Hi,

I noticed that the undo in VSCode is not working in some cases, for example when you create a decision or new input nodes (and so on).
In addition to those cases, it does not work when you set the type for the decisions and you try undo the steps (but actually in those cases I might agree that the undo should just work on the visual components, i.e. it should not undo stuff on the background like type of decisions and other properties).

using VS Code.

It will not let you place the task in the sub-process.

When we open a DMN file in VS Code extension, we get an option to include model from other dmns as shown in below snapshot.

But this option is not present in Online Editor. Will this be part of the roadmap?

Event sequence flows and gateway labels need to be moveable as they have overlap most of the time and we need to manually position them.

i.e. trying to use editor editing https://github.com/quarkusio/quarkus-quickstarts/blob/master/using-kogito/src/main/resources/org/acme/kogito/persons.bpmn2 you end up with a massive diff just to change the position of a box.

The actual diff is just a single parameter change.

if the plugin would pretty print the generated xml this would be a much smoother experience.

Hi all, I built the extension, how can I create a .vsix file?

Is there a DSL or a planned DSL (such as JSON or simplified JS) config that would allow customization of the properties panel in the process modeler?

Examples: Adding custom fields for specific types of input on specific activity types, adding help text to specific fields, adding templated configuration options such as "Connect to MS Graph" and it pre-populates all the configs, etc.

Thanks!

using vs-code. When select a sequence flow, the first click is most often to check the line's configuration, but the circle that adds a new node into the line for line adjustments is too aggressive and causes the line to move or change position when the user only wants to select the line.

Summary
DMN validation does not work in online-editor if the file being edited includes and uses types or decisions from another DMN file (Included Models feature). Looks like online-editor sends only the contents of the current file and does not include imported resources in the request payload.

Test Case

1. Open https://sandbox.kie.org/ -> Upload -> Select folder - select the folder with DMN files from validateIncludedIssue.zip. There are 2 DMN files in this folder: root.dmn and types.dmn. root.dmn imports types.dmn and contains a single "const" decision that returns a value of type "types.CustomType" defined in types.dmn. This is just for demo purposes, any case with Included Models will do.
2. Select "root" decision and try to edit it.

Expected Result
/jitdmn/validate endpoint successfully returns with errors / warnings / no messages - depending on the changes

Actual Result
/jitdmn/validate endpoint returns 500 http status code
DMN Runner logs:

msg: Caused by: java.lang.RuntimeException: Could not locate required dependency while importing DMN for namespace: https://kiegroup.org/dmn/_0D827E3F-36ED-4005-9632-3386FCC7C176, name: types, modelName: null.
msg: 	at org.kie.dmn.feel.util.Either.getOrElseThrow(Either.java:64)
msg: 	at org.kie.dmn.core.assembler.DMNAssemblerService.enrichDMNResourcesWithImportsDependencies(DMNAssemblerService.java:138)
msg: 	at org.kie.dmn.validation.DMNValidatorImpl$ValidatorBuilderImpl.internalValidatorSortModels(DMNValidatorImpl.java:329)
msg: 	at org.kie.dmn.validation.DMNValidatorImpl$ValidatorBuilderImpl.theseModels(DMNValidatorImpl.java:248)
msg: 	at org.kie.kogito.jitexecutor.dmn.api.ValidationResource.schema(ValidationResource.java:76)
msg: 	at java.lang.reflect.Method.invoke(Method.java:566)
msg: 	at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:170)

Root Cause
online-editor doesn't send the contents of the included resource in the payload:
{ "mainURI": "root.dmn", "resources": [ { "URI": "root.dmn", "content": "..." } ] }

Hey
I am looking at replicating similar features as: https://github.com/StephenOTT/Workflow-Linter and https://github.com/camunda/camunda-modeler-linter-plugin but for Kogito.

Has there been work on this capability within Kogito?

In the above links, I have combined two types of linting: UI Linter which parses in JS and displays in the UI, and then a server linter (which the UI can also use): where the server linter parses into the server presentation and runs a series of rules: This is great for modeler dev, but also deployment control to ensure processes/apps meet requirements and reduce bugs.

Initial review for server side lint led me to the https://github.com/kiegroup/kogito-runtimes/blob/main/jbpm/jbpm-bpmn2/src/main/java/org/kie/kogito/process/bpmn2/BpmnProcessCompiler.java class which is used for compiling the .bpmn file into a Process Definition / "BpmnProcess" ?

or ProcessCodegen.class?

Would love some general thoughts!

Thanks

This issue's purpose is to provide means for people to build Kogito Tooling using their forks of the DMN, BPMN and Test Scenario editors. To trigger a build, comment using the following format:

Build: {my-github-username}/{my-branch-name}

This will trigger a build of the downstream repositories and will take your branch into account. The resulting artifacts can be downloaded from the Artifacts tab on the triggered Workflow run.

I export some bpmn files from KIE workbench, then I found there is a bpmn2:task tag in bpmn file which this kogito-tooling is not currently supported. I tried to build and run the project. But I cannot found a way to modify it. Are there any instructions to show how to add support to this kind of task node?

    <bpmn2:task id="_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF" drools:taskName="CommonWorkItem" name="Name">
      <bpmn2:extensionElements>
        <drools:metaData name="elementname">
          <drools:metaValue><![CDATA[Name]]></drools:metaValue>
        </drools:metaData>
        <drools:onEntry-script scriptFormat="http://www.java.com/java">
          <drools:script><![CDATA[v.execute("some");]]></drools:script>
        </drools:onEntry-script>
      </bpmn2:extensionElements>
      <bpmn2:incoming>_8DFEDB4E-2DB3-48D2-955F-F8DDB4DF6902</bpmn2:incoming>
      <bpmn2:outgoing>_D5950703-3DF3-46FA-BBC9-ABDC197CA831</bpmn2:outgoing>
      <bpmn2:ioSpecification id="_LmiULhjNEeuldeHdBwNIyA">
        <bpmn2:dataInput id="_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_vInputX" drools:dtype="com.xiaomi.mifi.policy.model.ProcessVariable" itemSubjectRef="__7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_vInputXItem" name="v"/>
        <bpmn2:dataInput id="_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_TaskNameInputX" drools:dtype="Object" name="TaskName"/>
        <bpmn2:inputSet id="_LmiULxjNEeuldeHdBwNIyA">
          <bpmn2:dataInputRefs>_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_vInputX</bpmn2:dataInputRefs>
          <bpmn2:dataInputRefs>_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_TaskNameInputX</bpmn2:dataInputRefs>
        </bpmn2:inputSet>
        <bpmn2:outputSet id="_LmiUMBjNEeuldeHdBwNIyA"/>
      </bpmn2:ioSpecification>
      <bpmn2:dataInputAssociation id="_LmiUMRjNEeuldeHdBwNIyA">
        <bpmn2:sourceRef>v</bpmn2:sourceRef>
        <bpmn2:targetRef>_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_vInputX</bpmn2:targetRef>
      </bpmn2:dataInputAssociation>
      <bpmn2:dataInputAssociation id="_LmiUMhjNEeuldeHdBwNIyA">
        <bpmn2:targetRef>_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_TaskNameInputX</bpmn2:targetRef>
        <bpmn2:assignment id="_LmiUMxjNEeuldeHdBwNIyA">
          <bpmn2:from xsi:type="bpmn2:tFormalExpression" id="_LmiUNBjNEeuldeHdBwNIyA"><![CDATA[CommonWorkItem]]></bpmn2:from>
          <bpmn2:to xsi:type="bpmn2:tFormalExpression" id="_LmiUNRjNEeuldeHdBwNIyA">_7FB7AFF4-C7FC-4CB8-BA91-1C2643106FAF_TaskNameInputX</bpmn2:to>
        </bpmn2:assignment>
      </bpmn2:dataInputAssociation>
    </bpmn2:task>

consider the following:

<bpmn2:userTask id="_8B62D3CA-5D03-4B2B-832B-126469288BB4" name="First Line Approval">
      <bpmn2:extensionElements>
        <drools:metaData name="elementname">
          <drools:metaValue><![CDATA[First Line Approval]]></drools:metaValue>
        </drools:metaData>
      </bpmn2:extensionElements>

This is from process-usertask-quarkus example project.

When node instances are shown:

The Node Definition IDs are the unique identifier. But is it difficult to know what the ID is. There could be multiple tasks with the same name.

The definition ID should be viewable in the modeler and preferably modifiable to a user value. Would be even better if the IDs were shorter such as "Activity_8f9we8f9", given that a activity is stopped within a Process Instance ID.

Issue Type: Bug

In the explorer view, click a file with .bpmn extension. The editor show an error message "Editor content has not been set."

Extension version: 0.15.0
VS Code version: Code 1.62.3 (ccbaa2d27e38e5afa3e5c21c1c7bef4657064247, 2021-11-17T07:59:13.865Z)
OS version: Darwin x64 19.6.0
Restricted Mode: No

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30384385
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsqsis300:30402085
vsaa593cf:30376535
vssld246cf:30401891
vscop804cf:30404767
vs360:30404995

Sorry @ederign I tried to open my folder with code --enable-proposed-api kiegroup.vscode-extension-pack-kogito-kie-editors but still, I am getting a blank screen.

Is there anything I have to do on VSCode to make it running.
If u see in my screenshot, all my bpmn, bpmn2 and dmn files are getting opened in Kie Kogito Editors view only.

Please help. I know to work with VSCode but not an expert.

Originally posted by @rahgadda in #133 (comment)

When switching between activities in a BPMN, you have tabs/sections such as Implementation/execution or Adv Data: It is difficult to compare configurations because after every activity change the user needs to re-open the section.

it would be great if the sections would stay open based on the user's previous actions or something similar.
Thanks

using vs-code

I have used KIE workbench for quite a long time but I wanna search for an alternative tool to modeling Guided Decision Table and Business Process. I found this kogito tool provider a great model tool for BPMN and DMN, but I cannot found any editor for GDST file. Is there any plan for it?

using vs code.

when you zoom out, the buttons get very small rather than scaling.

Hi!

I don't see any options in the palette to create pools, and then add lanes in it.

Is there a way to do this in VSCode?

Absolute n00b here...

Build: romartin/BAPL-678

Hello, I hope this is the right bug tracker for my issue.

I have a DMN model, exported from the KIE sandbox as the following ZIP file test-list-combiner.zip.

There are two leaf filters which return either "Rejected" or "Approved". A list kind decision box aggregates its results in a list. Then the top level decision boxes evaluate this list. If there is at least one "Rejected", the result is "Rejected". Otherwise it's "Approved".

The problem is on how the evaluation nodes are implemented. As show below, the FEEL expression is used in the output column and this setup is working correctly.

However, when I have this other setup below, the rejected state is not picked up from the list.

Any idea of what's going on?

When you download your DMN model file from the online editor it keeps new-file as the internal model name.
You can only change this in the raw XML.

<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="https://kiegroup.org/dmn/_FC75913D-81CF-49A3-A6F4-A56FB341C574" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_72BA4308-069E-4F8D-8608-D4FDDFA5A1A5" name="new-file" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="https://kiegroup.org/dmn/_FC75913D-81CF-49A3-A6F4-A56FB341C574">

using vscode. If you try and modify or delete a process variable and that variable is being used in another activity (such as in Input/Output mappings), the delete button does not do anything and if you try and modify the name of the variable, it just returns to its original value. There needs to be some error messaging indicating why you cannot modify/delete the variable and where to find the associated configurations. Otherwise the user has to click around into each activity and into each input/out to find the various configurations.

Would be even better if there was a Variable usage inspector that showed the tree of usage for process variables. This would be a huge time saver!

https://github.com/kiegroup/kogito-tooling/blob/master/packages/core-api/package.json#L15-L18

One think I noticed working on the AtlasMap POC is that I was getting the Invalid Hook Call Warning
error in the console. Ultimately, it was due to @kogito/core-api declaring React as direct dependency, which causes for multiple versions of React being embedded in the bundle. Since AtlasMap is written solely using hooks, this issue come up immediately.

A quick workaround was to instruct WebPack to consider React an external dependency, but it would be better to make React and React DOM peer dependencies in the core-api package.

Problem

According to Example including DMN Models when using the Include Model capability to include another DMN model, which does work there should then be a Decisions Components panel in the Editor which does not work.

How To Replicate

1. Create two DMN files (T1.dmn, T2.dmn)
2. In T1.dmn, Include Model T2.dmn (succeeds)
3. In T1.dmn Editor, T2.dmn components should appear under Decision Components (fails)

If you manually drag the switch it shows, but the switch is broken and then shows Yes and no.

using vs-code

Hi Team,

I tried installing 0.4.0 (alpha) version and unable to load persons.bpmn2 file i my VSCode.
I have attached screenshots of the issue that I am facing.

Regards,
Rahul

Holding Alt and then trying to pan does not work. It can sometimes work for horizontal scrolling, but never works on vertical scrolling.

Consider endpoints such as:

...

and config that looks like this:

(Answer: There are only two task endpoints generated, but there are three unique task definitions)

The Name/TaskNames are not unique and not enforced to be unique during deployment.

In the XML we have the ~true unique name:

<bpmn2:userTask id="_8B9E78DF-5DCE-44D1-B37E-707166B06BC4" name="My Task Name&#10;Row 2">
...
<bpmn2:userTask id="_FFCD0178-2716-4E16-B593-692770BC9E8B" name="Task">
...
<bpmn2:userTask id="_4AD34142-F892-439D-AA0C-6AB8C4B95999" name="Task">

ignoring the ~weird drools extensions that get auto added for a moment:

      <bpmn2:userTask id="_4AD34142-F892-439D-AA0C-6AB8C4B95999" name="Task">
        <bpmn2:extensionElements>
          <drools:metaData name="elementname">
            <drools:metaValue><![CDATA[Task]]></drools:metaValue>
          </drools:metaData>
        </bpmn2:extensionElements>
...

The id for a bpmn element is usually the unique identifier. The ID is not super friendly at the moment, and understandably someone chose something in the BPMN that would be cleaner. Would this suggest that Kogito wants to enforce unique Drools meta values ? IMO would be MUCh cleaner for XML readability if the extension was not used and the id property was used here. makes it much easier to read node execution history events as well.

Either way, the at the moment the problem is endpoints do not get generated as expected. If we are saying that this is expected because the task instance ID would be unique, then why are we generated named endpoints (where the task endpoint has the Task Name in the url)? the answer seems to be so so you could have Schema support for each task, and if that is the case then we seem to be back to the issue described above.

i have vs code 1.46.0 have installed the kogito bundle 0.5.0 after restart of vs code and starting it up with code --enable-proposed-api kiegroup.vscode-extension-pack-kogito-kie-editors and opening bpmn2 files i see just black screen

https://user-images.githubusercontent.com/35398860/84368047-5cb57100-abd5-11ea-87c3-a8aea5e469e3.png

Kogito requires that a embedded sub process contains a blank start event. The start event should be added by default.

[Using Kogito Bundle in VS code on Windows.
When I try to include another DMN in the current DMN via "Include Models" > "Include Model", I dont see the existing DMNs in the "Models" drop down list even though the DMNs exist in the same directory.

However this issue doesn't seem to happen on a Linux Desktop.

Using Kogito Bundle v0.8.0

[Window Title]
Visual Studio Code

[Main Instruction]
Visual Studio Code

[Content]

Version: 1.51.1 (user setup)
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-10T23:34:32.027Z (1 wk ago)
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

There is no section about how to setup the environment for the building from source at https://github.com/kiegroup/kogito-tooling/blob/master/README.md#build-from-source . What are minimal required versions of NodeJS, NPM, Yarn or any other tool like lerna.

I use @kogito-tooling/kie-editors-standalone:^0.14.0 BpmnEditor

ERROR org.drools.core.xml.ExtensibleXmlParser - Node Info: id: name:
Parser message: (null: 13, 45): cvc-elt.1.a: Element not found 'bpmn2:definitions' Statement of。

I found the bpmn file context xmlns:xsi="xsi" Should be xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

The docs say that Non-Interrupt events work in the engine. But the modeler does not have them available.

haha Are they hidden? because i cannot for the life of me find them.

vs code with kogito tools extension

Currently if you apply a boundary event on a task and apply a label/name to the event, the text is placed below the event. This causes overlap of text on the task. It makes it ~impossible to read. The labels should be positionable.

The modeler provides helpers such as the Actor and Group selection field:

But these fields make is very difficult to reuse configuration across BPMNs or across different tasks.

Consider that a UT will have multiple actors and multiple groups applied to it. I then decide i need to copy values from UT1 into UT2. UT2 already has a series of configurations applied, so i cannot just delete UT 2 and copy the entire UT1. I need to be able to easily copy the values from UT1 and apply them into UT2.

current we have to open the props panel to set the name of a sequence flow. not being able to double click really slows down the creation of gateway logic and documenting the process

using vs code latest release.

In the Properties tab the Advanced Data section reads as "AdvancedData"

how do I add a BPMN:Property through the editor?
If I use the properties advanced option its adding a meta tag

When Installing Chrome extension 0.2.6 I get the following error:

Permission '://.github.com' is unknown or URL pattern is malformed.

I am installing project kie-editors-standalone，it failed， because that kogito-tooling/build-env cannot be download. I searched it on npmjs, it cannot be found. could you kindly upload kogito-tooling/build-env package to npmjs?

When building processes, a common process is to mock out the entire process and leave certain steps as "manual task" steps which are skipped over by the engine, until that task is ready for implementation.

This allows the business to understand the process they want to build, and the developer to build/code in parallel.

It seems that there is no Manual Task supported in the modeler, and you cannot leave the task as a non task, as Kogito will return:

a Validation error of: "...Task has no task type."

Other than add everything as a user task, or a script task, etc, is there a viable alternative?

Was manual task omitted by design?

Thanks!