Git Product home page Git Product logo

Comments (3)

andygrove avatar andygrove commented on June 20, 2024 2

Sorry, but I'm not a fan of this approach. I think it is good to avoid circular dependencies of any kind. We should use rustdoc only to document the contents of a crate and not need to reference "parent" crates.

I think that the real issue here is that we don't have a good way yet to have end-to-end user documentation that includes Rust fragments that are tested for correctness. I would prefer that we find a solution to that problem.

from arrow-datafusion.

Omega359 avatar Omega359 commented on June 20, 2024 1

Closing as won't do.

from arrow-datafusion.

alamb avatar alamb commented on June 20, 2024

cc @andygrove

I am not 100% convinced that having the circular back references as dev-dependencies is a good idea (as it complicates / slows down cargo test -b <crate>

If we need to depend on more crates, pulling the tests into datafusion_core is probably the better approach

from arrow-datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.