Git Product home page Git Product logo

Comments (5)

xinlifoobar avatar xinlifoobar commented on June 18, 2024 1

Hi @alamb, I am wondering whether is there a way to implement the cube and 'rollup' functions easily. the inner vector is expanded in the planner.

from arrow-datafusion.

alamb avatar alamb commented on June 18, 2024 1

Hi @xinlifoobar - another thing that we could potentially do is to work at this from the SQL statement level (rather than the Expr level)

As in implement a round trip test like this for a query with a grouping set:

https://github.com/apache/datafusion/blob/main/datafusion/sql/tests/sql_integration.rs#L4678-L4708

from arrow-datafusion.

xinlifoobar avatar xinlifoobar commented on June 18, 2024

I think from the Vec<Expr> could not mapping back to the only unique Vec<Vec<Expr>> and hence unparse the cube statement would be difficult. How about store another copy of origin Vec in the Cube and Rollup instance? i.e.,

pub enum GroupingSet {
    /// Rollup grouping sets
    Rollup(Vec<Expr>, Vec<Vec<Expr>>),
    /// Cube grouping sets
    Cube(Vec<Expr>, Vec<Vec<Expr>>),
    /// User-defined grouping sets
    GroupingSets(Vec<Vec<Expr>>),
}

from arrow-datafusion.

xinlifoobar avatar xinlifoobar commented on June 18, 2024

I made a mistake about the previous statements. The vector of cube and rollout is not expanded so the implement could be easy.

https://github.com/apache/datafusion/blob/main/datafusion/sql/src/expr/grouping_set.rs#L42-L81

from arrow-datafusion.

alamb avatar alamb commented on June 18, 2024

Thanks again @xinlifoobar

from arrow-datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.