Comments (6)
Probably this is the reason why...both str
are simply compared. I'm not sure if it makes sense to just 'add' another rule when checking...or if one has to come up with a better fix / design if there are other cases that have to be supported or checked as well?
from arrow-datafusion.
Technically now()
is wrongly defined, it explicitly states it's in "UTC" in the docs.
from arrow-datafusion.
I'd be happy to create a pool to start adding special cases, but that sounds like a rabbit hole.
from arrow-datafusion.
I think the chrono-tz crate has the special cases / knows how to handle converting "UTC" to "+0:00" so I don't think we would have to make a special datafusion map
The arrow crate has a "chrono-tz" feature which activates it. I wonder if we have to turn that on somewhere 🤔 https://crates.io/crates/arrow or maybe use an appropriate check in datafusion
from arrow-datafusion.
I am responding to @marvinlanhenke 's comment #10960 (comment)
Since "+00:00" and "UTC" are the 'same' - is this viable? Or do we have to extend the logic here in order to provide both variants (and possibly not introduce a breaking change)?
I think that "UTC" == "+00:00"
might be a reasonable special case to include
So perhaps we could update the timezone comparison check to compare those two types the same 🤔
from arrow-datafusion.
#10960 from @marvinlanhenke is up for review 🙏
from arrow-datafusion.
Related Issues (20)
- Register SQL planners in `SessionState::new()` HOT 4
- Implement user defined planner for `date_part`
- Implement user defined planner for `create_struct` HOT 1
- Implement user defined planner for `create_named_struct` HOT 1
- Implement user defined planner for `sql_overlay_to_expr` HOT 1
- BinaryOp supporting multiple parameters in Substrait
- Support `COUNT()` in addition to `COUNT(*)` HOT 1
- Replace `println!` with `assert!` if possible in DataFusion examples HOT 3
- Implement Substrait support for SubqueryType::Scalar
- HashJoin for nested types give wrong results
- Clean Up Data Page Statistics Tests and Fix Bug HOT 1
- Implement user defined planner for sql_position_to_expr
- Implement user defined planner for `sql_compound_identifier_to_expr`
- Implement user defined planner for `sql_substring_to_expr `
- Implement user defined planner for `sql_position_to_expr`
- `where` clause incorrectly reject `NULL` literal (by SQLancer-NoREC) HOT 1
- Make error message better when `bitwise_*` operator takes wrong argument type HOT 1
- Improve error message for wrong argument type in operators
- Error evaluating clause `where COL_BIGINT < 1e100` (Found by SQLancer-NoREC) HOT 1
- `CASE` with `NULL` branch does not coerce when passed to aggregate function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arrow-datafusion.