anz-bank / go-slides Goto Github PK

Either:

• delete continued
• use continued everywhere
• use (1/2), (2/2) etc. everywhere.

Sam Uong asked for this to be added.
IIRC he mentioned:

• not everything is Object Oriented, use (pure) functions where you can - more testable & readable
• don't worry about interfaces before implementation
• don't overstructure
• don't worry about patterns
• don't worry about frameworks (use libraries rather than frameworks)

Needs maybe some more research on the internet.

NN_lab_name for :

• Lab 1 - Fibonacci
• Lab 2 - Bubble sort
• Lab 3 - Letter frequency
• Lab 4 - Numeronym
• Lab 5 - Stringer
• Lab 6 - CRUD puppy with interface
• Lab 7 - Errors
• Lab 8 - Project Layout
• Lab 9 - JSON puppy
• Lab 10 - Puppy REST
• Lab 11 - Puppy Notifications

• In last course people reported strongly diverting results.
• Re-run sample code.
• Work out if the load of concurrent requests can be increased (something todo with open socket limit in OS)
• Include chart of go vs java performance: x axis: thousands of concurrent requests, y-axis: median & 90th percentile response time.

• Synchronization primitives in sync package
• What are the primitives in sync package used for
• Explain WaitGroups with an example

See

• @anz-rfc sample code: https://play.golang.org/p/Oj-XFOKtiNq
• @camh-anz reference to wiki: https://github.com/golang/go/wiki/PanicAndRecover
• blogpost: https://blog.golang.org/defer-panic-and-recover

• JSON (un)marshal
• JSON en|de code (and difference to marshal)
• JSON tags on structs, omit empty
• When to use pointers (when JSON properties are optional and null value is insufficient sentinel)

send out update email announcing Andrew Gerrands Talk

• Processes, Threads and OS Scheduling
• Go Scheduler / Runtime
• Goroutines
• Wait Group
• Channels
• Select

Use #go-training or similar on anzengineering workspace and add info to slides.

Update CODEOWNERS file in go-training.

Especially git examples have new and log etc. highlighted incorrectly.

Slides need more details and samples on how embedding works (see effective go).
Slide: http://gotraining.appspot.com/gotraining.slide#50

• Use contents from this gist
• Add link to slides as http://go-course.org/
• Add separate callout to Sack channel #go-course

• How is error represented in go
• Language's design philosophy on error handling
• How to create error values
• How to implement a custom error type
• How are errors handled

Add Josh and Dan
Remove Angelo

One of the biggest things missing from samples is good examples of testing. In particular examples for...

• native testing
• testify
• suites with testify

Slide Iterable data types and Range Maps example has a few India specific references:

• Map: https://goplay.space/#lMZT_vCRchI
• Range: https://goplay.space/#S3KObilbh7H
• Func
• Update sample links in slides!

Please also add source files to the sample directory.
Also add the 3 embedding examples from a previous PR.
For this samples/README.md will need an update too.

Angelo and Sai as members to anz-bank github org and as go-team members.

Remind them:

Invitations are sent via email and can be accepted at https://github.com/anz-bank

Update the tests for the hello world sample at https://github.com/anz-bank/go-course/blob/master/00_hello_world/juliaogris/main_test.go

Remove //Given //Then /when

Use go testing rather than testify.

Include reference to this sample in lecture (maybe speaker notes, maybe in link in slides for lab setup).

Would like a slide with links for more topics that aren't covered in the course in detail or at all,
eg:

• Benchmarks
• CPU and memory profiling
• Code coverage
• Compiler features (GOOS, GOARCH, CGO)
• Modules

These are out of scope of the course, but interesting topics in their own right. Any more ideas?

I (camh-anz) will be presenting this part, and I don't think I should quote myself. Just put it in as a bullet point, not a quote.

Add information on tagging logic
Link approval checklist https://github.com/anz-bank/go-course#pre-pr-checklist

Explain labelling for own PR:

We use labels to avoid concurrent reviews and filter more easily on PRs that require action.
When your PR is ready:

• label with lab number e.g. lab1
• label with Ready for review (first time and after changes)
• wait for review and labels Changes requestedor Approved by colleague
• wait for code CODEOWNER (trainer) to approve and add tag Merge me
• merge PR

Explain labelling for reviewing others' PRs:

Review somebody else's PR in order to get own PR merged.
Add link to review comments of other PR to own PR descriptions (does not have to be the same lab).

• add label Under review while reviewing
• add label Changes request or Approved by colleague when review is done

re: slide 35, zero values

nitpicks:

• could comment on zero value of "nil for pointers, functions, interfaces, slices, channels, and maps. "
• could add link to golang language spec: https://golang.org/ref/spec#The_zero_value

re: slide 38, fibonacci

aside:

• could link to OEIS entry for fibonacci sequence https://oeis.org/A000045

re: slide 41, letter frequency

aside:

• extension: it's often more useful to sort by frequency. i.e. sort (letter, count) items first by count (descending), then by letter.

re: slide 43, numeronyms

what is a "numeronym"?
is there some standard way to generate them or are they just a handcrafted lookup table?

re: slide 51, "concurrency"

aside: re "concurrency vs parallelism", i found this discussion of parallel vs concurrent interesting:

http://yosefk.com/img/n/parallelism-centric.png

https://yosefk.com/blog/parallelism-and-concurrency-need-different-tools.html

Add github usernames from spreadsheet (ask @juliaogris for details)
to https://github.com/anz-bank/go-course/settings/collaboration

Give users write access to the repo (necessary to merge PRs and add tags to PRs)

People who have given invalid usernames (might have been using internal GHE accounts) need to be contact by email.

• Include signup form
• Link to slides
• Dates
• Location
• Optional pre-word:
  • Tour of Go
  • Install Go 1.12 tool chain
  • Instal Golangci-lint
  • Repo forking and cloning instructions
  • Repo building instructions

Package and Function samples have references to Bangalore.

• Update samples on https://goplay.space
• Update links in slides and copy
• Update copy of samples inhttps://github.com/anz-bank/go-slides/tree/master/samples

• include new trainers and reference to new training in go-slides README.md
• update Pre-PR checklist go-training. add: review other PR section
• update Build, test etc. section: remove install and add build

• What is defer
• How defer works
• Demonstrate its usage

When I was running these two commands:

git remote update will output:

Fetching origin
Fetching upstream
fatal: unable to access 'https://github.com/anz-bank/go-course.git/': Operation timed out after 300031 milliseconds with 0 out of 0 bytes received
error: Could not fetch upstream

Using the SSH url [email protected]:ethanyoung/go-course.git for the upstream can solve this problem.

Update slides and README.md of go-training repo

Pre-requsites

• Install go 1.12
• Install golangci-lint

Repo cloning instructions

1. Fork https://github.com/anz-bank/go-training to your github account
2. Clone https://github.com//go-training.git

Explain labelling for own PR:

We use labels to avoid concurrent reviews and filter more easily on PRs that require action.
When your PR is ready:

• label with lab number e.g. lab1
• label with Ready for review (first time and after changes)
• wait for review and labels Changes requestedor Approved by colleague
• wait for code CODEOWNER (trainer) to approve and add tag Merge me
• merge PR

Explain labelling for reviewing others' PRs:

Review somebody else's PR in order to get own PR merged.
Add link to review comments of other PR to own PR descriptions (does not have to be the same lab).

• add label Under review while reviewing
• add label Changes request or Approved by colleague when review is done

The "Motivation & Demo" section is a little disjoint. The Motivation slide would work better in the "History and Overview" section, leaving the demo as a separate section. This also allows the demo to be presented by a different presenter to the overview.

Rework this repo to become a generic ANZ engineering education location for slides.

• Rename repo from go-slides to slides or anz-slides or similar
• Move everything go-training specific into content/gotraining/ including pingserver
• Use generic GCP project (anztraining and anzedu have already been acquired by @juliaogris)
• Use generic short URL for training location edu.anz or similar would be cool
• Move go present files (top level *.go) into tool/ or present/

• What are panic and recover
• How they work
• How and when to use panic and recover
• Examples

Remove feedback slide or replace with something available on corp network or ask people to use phones?

Create an outlook Distribution List (DL) with all training participants.
Include instructors & Marcelo, Sam & Brendan in list

• Send an outlook calendar invitation for all training dates to DL. No lecture 10 June! (public holiday)
• Send a reminder email with and advise people to join #go-course even if they don’t have any questions. No lecture on 10 June!!

Issue reported here as issues on go-training repo are used for lab assignments.

• Processes, Threads and OS Scheduling
• Go Scheduler / Runtime
• Goroutines

Update the README.md to include instructions on how to deploy your local changes that you have submitted for review. A reviewer needs to see the final result so all PRs that change the slides should be accompanied by a PR deployment.

It may be possible to automate this, such that the PR version is deployed on PR creation and update and deleted when the PR is closed, but I'm not sure how github and gcloud are integrated since I need admin on the repo and gcp project to find that out.

• What is a Channel
• How to create a channel
• Buffered vs. Unbuffered channels
• Write to a buffered and unbuffered channel
• Read from an buffered and unbuffered channel
• Read using range and using boolean to determine channel state (open/closed)
• Passing channel direction as function argument.

What would it require to record the lectures?
My meeting?
Can we record audio and slides?
Audio, video and slides?

Can we put it on youtube? (everything else is open source).

Somebody also mentioned putting recordings on OWL or so. Another thing to chase down possilby.

https://github.com/Checkmarx/Go-SCP
https://github.com/guardrailsio/awesome-golang-security

Following slides/examples have references to Bangalore and/or non English text -

Getting Started

• https://goplay.space/#ZgnRgImb2mv (Kannada text)
• https://goplay.space/#0sIugrcfh_z (Kannada text)

Values and control flow: Variables

• https://goplay.space/#gs20cFjl-gs (nit: uses shanti)

Values and control flow: Constants

• https://goplay.space/#2X57Ha4ldNV (Kannada text)

Functions

• https://goplay.space/#gHOzTi05LkI (nit: refers to Bengaluru & Melbourne)