antonfisher / react-express-webpack Goto Github PK

Hi antonfisher,
Thanks for your repo.
I am a frontend beginner, and start to learn webpack.
may I know the reason you place
if (req.url !== '/' && !req.url.includes('.')) { request('http://localhost:${process.env.APP_PORT}/', (error, response, body) => res.end(body)); } else { res.sendFile(resolve(compiler.outputPath, 'index.html')); }
in the app.get('*', ...
I try to remove this and use only res.sendFile(resolve(compiler.outputPath, 'index.html'));, it fails.
I know this is a workaround, but have you figured out a decent way to fix it?

Thanks,
Chen

Hello,
Thank you for a great boilerplate.

The build scripts works as expected on Linux and Mac. I have also tested the boilerplate on windows 10, and needed to apply some small modifications to package.json to build the project.

If you would like to make the boilerplate "windows friendly", here are the steps required:

Install the following packages:
npm i -D cross-env rimraf copyfiles

Modify scripts:

  "scripts": {
    "dev": "cross-env NODE_ENV=development node ./src/server",
    "start": "cross-env NODE_ENV=production node ./build/server",
    "prebuild": "rimraf build",
    "build": "npm run build:client && npm run build:server",
    "build:client": "cross-env NODE_ENV=production webpack -p --display-error-details --config=config/webpack.config.prod.js",
    "build:server": "copyfiles -a -u 1 src/server/** build",
    "lint": "eslint --ignore-path .gitignore --ignore-pattern node_modules -- .",
    "prettier": "prettier --ignore-path .gitignore --write './**/*.js'",
    "test": "exit 1",
    "release:patch": "npm run lint && npx standard-version -r patch && git push --follow-tags origin master",
    "release:minor": "npm run lint && npx standard-version -r minor && git push --follow-tags origin master",
    "release:major": "npm run lint && npx standard-version -r major && git push --follow-tags origin master"
  },

Regards
Leif Olsen

Hi,
Thanks you for your effort to make this boilerplate. I am integrating this to my own app.
I found a bug when I use mobile web browsers.
In localhost/servers, it show a modal with 'API Error, Type error, URL:/api/stats'.
And this happens on both mobile safari and chrome.

Thanks,
Sheng