anthonyg-1 / pstcpip Goto Github PK

This is a small thing, but it makes a big difference in usability. You can modify your formatting XML to create an auto-sized table.
Here is your default output:

And auto-sized.

 <TableControl>
         <AutoSize />
        <TableHeaders>

Get-TLSInformation should have a default parameter set defined. I also suggest you make the parameter of the default to be mandatory.

I updated the module to 4.2.10, but Get-TLSInformation is missing a mandatory parameter.

I'm curious about the advantages of using your Test-TcpConnection command over Test-NetConnection. I like that your command lets me test multiple ports, but is there anything else? I'd put this information in the help and your readme file.

I suggest adding port 5986 to your port list for WSMan SSL connections. Another option would be to add commands to the module to let the user manage $tcpPortAndDescriptionData. I know I can do something like this:

$tcpPortAndDescriptionData[5986] = "WinRM/SSL"

But it is always nicer to give the user a command.

If your module only works in PowerShell 7, I suggest you use the module manifest to specify that requirement.

Because your module requires PowerShell 7, you should use ForEach-Object -parallel in Test-TCPConnection for performance. I tested with 4 machines, and it took over 1 minute. But using the parallel option only took 18 seconds. Yes, I know the user could run this:

"srv1","srv2","dom1","srv3" | foreach-object -Parallel { Test-TcpConnection -HostName $_}

But you could make your command easier and faster by adding this internally so that this:

Test-TcpConnection -HostName srv1,srv2,dom1,srv3

Runs just as quickly.