ansys / pyprimemesh Goto Github PK

Make the README more concise and accurate to allow people to come in and get up and running swiftly with pyprime

While we work to get the example gallery up and running, we should add temporary links to example scripts so that users can atleast refer to them.

Quadratic tet element display does not show mesh edges correctly.

Could you share an update where you are with the refactoring the graphics issues seen with PyPrime?

Absolutely.

First, thanks Ninad for helping me get started with PyPRIME. I'd like to see the install docs and packaging (of the server) to be improved so it's not a huge pain to install, and thanks @ninad-kamat for all your help.

Were you able to reproduce the issue using pyprime? If so, were you able to identify the root cause for the issue seen?

I was able to reproduce the issue and fundamentally it comes down to a limitation with VTK:
https://discourse.vtk.org/t/vtk-is-slow-when-i-have-a-lot-of-actors-10000/2421

That being said, PyVista is also a contributor to the slowdown and I can improve the performance a bit, by as much as 50-60% depending on the platform.
pyvista/pyvista#2925

However, fundamentally the issue will still be on VTK's side. It's simply not designed to scale for 1000s of actors.

I'm researching a workaround. For now, pyvista #2925 will help a little bit.

if no sizing specified

Picking front face also selects back face.

As we transition to the new name as PyPrimeMesh, this issue can track any updates, questions, difficulties faced in this task.

Current output message from part summary result will only give max/min x,y,z coordinates of bounding box. It'd be useful to determine mesh sizing parameters based on the diagonal of bounding box.

files documenting the issue can be found below:

t-junction-original.pmdat.txt
t-junction-solids.ipynb.txt

(Cc. @akaszynski , @ninad-kamat )

Currently, when we use PIM a lot of extra customization is needed for starting a session, as well as for reading and writing files. We should have this dependency integrated within the library to provide the users a consistent experience when launching a prime session.

The changes proposed are

1. Adding support to detect PIM configuration and launching Prime through PIM. This is especially true with Ansys Labs.
2. When reading and writing files, we should ensure that we use the file service to upload and download the files.

instructions on how to run unit testing locally

There are errors when trying to install pyprime with "pip install -e .[graphics] --find-links deps" without having installed the build tools for msvc.

PyPrime repository has support for pre-commit and the contributing guide should explain how to use this to automatically format code. See the PyMAPDL code style guide for reference.

The example scripts need to be annotated with comments that will be picked up by the doc build to create the examples gallery

As has been discussed with the legal team at Ansys, a copyright statement in the License file is sufficient. Hence, all other copyright notices in python files should be removed.

Currently two sets of geometry files with differing setup for different examples.

Geometry needs consolidating into a single complete set of files (scdoc, fmd, pmdat) with appropriate example scripts. Capping API now available and workflow could be modified to account for this rather than using wrapper.

Here is one example of an image containing weird shapes in dark mode. This is not visible in light mode in documentation as the background is white.

It would be useful to have Triad and ruler added to UI for defining size controls.

Hello,

Should we be following similar example template as PyMAPDL so that html page for them is automatically generated on help page?

https://mapdl.docs.pyansys.com/examples/gallery_examples/03-tips-n-tricks/00-example-template.html#

Changes need to be made with latest guidelines from Alex's team to add example gallery to our documentation

The examples module will provide users access to a few publicly available example databases as a starting point for our tutorials. This is also vital to provide test cases for unit testing.

While I was navigating the PyPrime API reference, I found that certain APIs extend and overlaps with the content in the right pane which should not be the case.
Please see attached image.

Hi,

I am working on multiple jt files for external aero automotive preprocessing. In Automotive application it is a general scenario to import multiple cad files. Importing files in parallel will save lot of time of user.
Currently I am see slowness in jt import.

Rohit

cc : @ninad-kamat @rajesh1359 @schadha78 @waltersma @ansutremel

If multiple parts are displayed the surface selection does not provide a result.

WORKAROUND: display only a single part if selections are required. OR merge all parts into a single part.

The documentation needs to be made available through Github Pages

Publish a private Github docker image for Prime server. This is needed to run unit testing and documentation build with example gallery. This image should not be accessible to every one and is only to be used for Github Actions.

NOTE: This is not part of pyprime release

should model.control_data.get_scope_face_zonelets be model.ControlData(model).get_scope_face_zonelets?

if no labels are supplied all are used and the zone names are flattened. ie label1 overlaps with label2 for a portion of the face zonelets -> zone1(label1) zone2(label2) zone3(label1label2).

@akaszynski , @ninad-kamat just wondering if the below makes more sense as general guidance for doc home page navigation? Any thoughts?

Current, you get a cryptic message or a KeyError when the server does not have a license. Add a mechanism to let the client know if the server does not have a license

Change the CI/CD pipeline to publish documentation as part of the documentation build whenever there is a push to main.

For the API documentation for part can we include reference to TopoPart and MeshPart as Part types that are with and without TopoEntities.

Print(model) should also reference the type.

I will add description for Part Type to user guide.

@srpyprime, @ninad-kamat, @hlee0122, @AnsysAndy, @schadha78

Currently, build pipelines use --find-links deps and the local wheel to install. We need to switch to using PyAnsys PyPI in Github Actions. The major bottleneck at present for completing this is that ansys-api-meshing-prime==0.1.1 is not available on PyAnsys PyPI

https://github.com/pyansys/pyprimemesh/blob/main/src/ansys/meshing/prime/autogen/wrapper.py there's no connect here but I can still see the method in my local build...any idea? @ninad-kamat @srpyprime @waltersma