Git Product home page Git Product logo

Comments (5)

mkrizek avatar mkrizek commented on June 19, 2024 2

Looks like we just need to ensure we are operating on a copy of the handler.listen list before extending it for evaluation:

I was wondering if we could/should take it a step further and just do the work of validating/extending listen just once on task validation since listen is static #83400?

from ansible.

sivel avatar sivel commented on June 19, 2024 1

Looks like we just need to ensure we are operating on a copy of the handler.listen list before extending it for evaluation:

diff --git a/lib/ansible/plugins/strategy/__init__.py b/lib/ansible/plugins/strategy/__init__.py
index efd69efe9b..9cba974d07 100644
--- a/lib/ansible/plugins/strategy/__init__.py
+++ b/lib/ansible/plugins/strategy/__init__.py
@@ -558,7 +558,7 @@ class StrategyBase:
                     handler.fattributes.get('listen'),
                     listeners,
                     templar,
-                )
+                ).copy()
                 if handler._role is not None:
                     for listener in listeners.copy():
                         listeners.extend([

from ansible.

ShawnHardwick avatar ShawnHardwick commented on June 19, 2024 1

Seems like that suggested fix works.
playbook_output.txt

from ansible.

ansibot avatar ansibot commented on June 19, 2024

Files identified in the description:

None

If these files are incorrect, please update the component name section of the description or use the component bot command.

from ansible.

briantist avatar briantist commented on June 19, 2024

Since this problem affects 2.17 as well as 2.18, it would be great if whichever PR is chosen is a candidate for backporting. I can't really tell whether @mkrizek 's #83400 or @ShawnHardwick 's #83393 is more or less of a candidate for that, just mentioning it since it's important to us and affecting all of our internal collection testing.

from ansible.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.