anshuman73 / commitstrip-scraper Goto Github PK

URLS like - " http://www.commitstrip.com/wp-content/uploads/2016/01/Strip-Les-câbles-du-laptop-650-finalenglish.jpg " contain unicode characters and thus throw an error in urlretrieve().

Possible fix could be to convert this to a properly encoded url. Tests show that in that way, the strip can be downloaded.
For example, for the link above, urlretrieve('http://www.commitstrip.com/wp-content/uploads/2016/01/Strip-Les-c%C3%A2bles-du-laptop-650-finalenglish.jpg') works fine.

Currently, the program does not provide an extension to the file name. This works fine on Linux (Tested with Ubuntu 14.04) but doesn't seem to work with Windows as it requires file names. Testing on OSX is also required.
we cannot simply append ".jpg" to the file name as each image is different. We will have to get each file extension and put it explicitly.

Possible Fix - the link has the file extension mentioned. the same can be parsed and added to the file name to make this work.